You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: COMMITTERS.adoc
+2-1Lines changed: 2 additions & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -37,7 +37,8 @@ While not absolute, here is some advice:
37
37
look if interested.
38
38
If the PR is very large or is a new extension, better let it
39
39
bake for a few days.
40
-
* We do _merge commits_ so please ask the author to properly squash the commits before merging (when it makes sense).
40
+
* A pull request may not contain _merge commits_ (it makes backporting a lot harder) or `fixup!` commits.
41
+
* We merge pull requests with _merge commits_ so please ask the author to properly squash the commits before merging (when it makes sense).
41
42
The idea is to have proper semantic commits. Several commits are not a problem as long as they have a proper semantic.
42
43
If the author is not familiar with Git or not available, you can also (carefully)
43
44
https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/committing-changes-to-a-pull-request-branch-created-from-a-fork[do it for them]
0 commit comments