Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Extension Proposal] SQLite4j JDBC - sqlite in pure java #46063

Closed
andreaTP opened this issue Feb 4, 2025 · 11 comments · Fixed by quarkiverse/quarkiverse-devops#319
Closed
Labels
area/jdbc Issues related to the JDBC extensions area/quarkiverse This issue/PR is part of the Quarkiverse organization kind/extension-proposal Discuss and Propose new extensions

Comments

@andreaTP
Copy link
Contributor

andreaTP commented Feb 4, 2025

Description

We already have an extension in the Quarkiverse leveraging the stable and mature xerial/sqlite-jdbc driver: quarkus-jdbc-sqlite.

I just finished the port of the driver to pure Java leveraging Chicory, you can find the relevant repo here.
In the "Design decisions" section there is a collection of motivations that makes the two drivers "different enough" to be alternatives depending on the environment.

I initially explored sending a PR to the current extension, even having received an answer, I'm now convinced that the two projects are different enough and people would not be happy to switch the JDBC driver without them knowing.

Repository name

quarkus-sqlite4j

Short description

SQLite driver for Quarkus with Agroal in pure Java built on SQLite4j

Repository Homepage URL

https://docs.quarkiverse.io/quarkus-sqlite4j/dev/

Repository Topics

  • quarkus-extension

...

Team Members

Additional context

I prepared a ready to ship (🤞) repository under my account that can be easily transferred preserving attributions:

https://github.com/andreaTP/quarkus-sqlite4j

@andreaTP andreaTP added area/quarkiverse This issue/PR is part of the Quarkiverse organization kind/extension-proposal Discuss and Propose new extensions labels Feb 4, 2025
@quarkus-bot quarkus-bot bot added the area/jdbc Issues related to the JDBC extensions label Feb 4, 2025
Copy link

quarkus-bot bot commented Feb 4, 2025

/cc @aloubyansky (extension-proposal), @barreiro (jdbc), @gastaldi (extension-proposal), @gsmet (extension-proposal), @maxandersen (extension-proposal)

@Sanne
Copy link
Member

Sanne commented Feb 4, 2025

Awesome, thanks @andreaTP !

@yrodiere
Copy link
Member

yrodiere commented Feb 4, 2025

Great idea, the existing extension wouldn't be a great place for this given the different dependencies.

We may want to look into using conditional dependencies for the hibernate-community-dialect part... I'll see if I can get to this once I merged the PR for Derby (#41310)

@andreaTP
Copy link
Contributor Author

andreaTP commented Feb 4, 2025

oh, wow, that would be really appreciated @yrodiere !

@melloware
Copy link
Contributor

+1 on this...

@gastaldi
Copy link
Contributor

gastaldi commented Feb 4, 2025

https://github.com/quarkiverse/quarkus-sqlite4j is now available, enjoy!

@andreaTP
Copy link
Contributor Author

andreaTP commented Feb 5, 2025

Thanks @gastaldi !

@melloware
Copy link
Contributor

melloware commented Feb 5, 2025

@gastaldi for consistency shouldn't it be quarkus-jdbc-sqlite4j to be consistent with other JDBC extensions?

@gastaldi
Copy link
Contributor

gastaldi commented Feb 5, 2025

@melloware ah right, I forgot about that. @andreaTP any problem if I change the repository name?

@gastaldi
Copy link
Contributor

gastaldi commented Feb 5, 2025

The artifact Id would probably need to be renamed as well

@andreaTP
Copy link
Contributor Author

andreaTP commented Feb 5, 2025

Oh, sorry for the delay, I have no big issues with the naming, I removed the -jdbc- infix as it's already in the groupId: io.quarkiverse.jdbc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/jdbc Issues related to the JDBC extensions area/quarkiverse This issue/PR is part of the Quarkiverse organization kind/extension-proposal Discuss and Propose new extensions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants