Skip to content

Make org.graalvm.sdk:nativebridge dependency parent first #50288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gsmet merged 1 commit into from
Sep 26, 2025
Merged

Make org.graalvm.sdk:nativebridge dependency parent first #50288

gsmet merged 1 commit into from
Sep 26, 2025

Conversation

@geoand
Copy link
Contributor

@geoand geoand commented Sep 25, 2025

@geoand geoand requested a review from gsmet September 25, 2025 15:48
@geoand geoand mentioned this pull request Sep 25, 2025
Closed
gsmet
gsmet reviewed Sep 25, 2025
View reviewed changes
core/runtime/pom.xml
<parentFirstArtifact>org.graalvm.sdk:word</parentFirstArtifact>
<parentFirstArtifact>org.graalvm.sdk:collections</parentFirstArtifact>
<parentFirstArtifact>org.graalvm.sdk:native-bridge</parentFirstArtifact>
<parentFirstArtifact>org.graalvm.sdk:nativebridge</parentFirstArtifact>
Copy link
Member

@gsmet gsmet Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn typo!

@gsmet
Copy link
Member

gsmet commented Sep 25, 2025

If I'm not mistaken, you introduced the duplicate in your first commit so maybe you should squash?

@geoand
Copy link
Contributor Author

geoand commented Sep 25, 2025

Oh I didn't realize that. I'll fix when i get back because I'm on the phone now

@gsmet
Copy link
Member

gsmet commented Sep 25, 2025

No worries, fixed and pushed!

@geoand
Copy link
Contributor Author

geoand commented Sep 25, 2025

Thank you!

@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 26, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 72a5ec7.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand requested a review from gsmet September 26, 2025 06:45
@gsmet gsmet merged commit d703f11 into quarkusio:main Sep 26, 2025
163 of 166 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.29 - main milestone Sep 26, 2025
@gsmet gsmet modified the milestones: 3.29 - main, 3.28.2 Sep 29, 2025
@gsmet gsmet modified the milestones: 3.28.2, 3.27.1 Oct 22, 2025
@gsmet gsmet moved this to 3.27.1 in Backports for 3.27 Oct 22, 2025
@fedinskiy
Copy link
Contributor

fedinskiy commented Dec 2, 2025

@geoand what about this line: https://github.com/quarkusio/quarkus/blob/main/core/runtime/pom.xml#L239 ?

@geoand geoand deleted the #50251 branch December 2, 2025 16:32
@geoand
Copy link
Contributor Author

geoand commented Dec 2, 2025

What about it?

@fedinskiy
Copy link
Contributor

fedinskiy commented Dec 2, 2025

It contains native-bridge and not nativebridge. Shouldn't it and https://github.com/quarkusio/quarkus/blob/main/core/runtime/pom.xml#L177 be the same?

@geoand
Copy link
Contributor Author

geoand commented Dec 2, 2025

Ah, you are right! As you spotted it, would you like to open a PR to fix it?

@fedinskiy fedinskiy mentioned this pull request Dec 2, 2025
Open
fedinskiy added a commit to fedinskiy/quarkus that referenced this pull request Dec 2, 2025
@fedinskiy
Use correct name for org.graalvm.sdk:nativebrdige dependency
f02294f 
The dependency can be found here:
https://central.sonatype.com/artifact/org.graalvm.sdk/nativebridge
Follow-up to quarkusio#50288
@fedinskiy
Copy link
Contributor

fedinskiy commented Dec 2, 2025

@geoand done: #51341

fedinskiy added a commit to fedinskiy/quarkus that referenced this pull request Dec 3, 2025
@fedinskiy
Use correct name for org.graalvm.sdk:nativebrdige dependency
ed8d3df 
The dependency can be found here:
https://central.sonatype.com/artifact/org.graalvm.sdk/nativebridge
Follow-up to quarkusio#50288
fedinskiy added a commit to fedinskiy/quarkus that referenced this pull request Dec 4, 2025
@fedinskiy
Use correct name for org.graalvm.sdk:nativebrdige dependency
01b6335 
The dependency can be found here:
https://central.sonatype.com/artifact/org.graalvm.sdk/nativebridge
Follow-up to quarkusio#50288
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gsmet gsmet gsmet approved these changes

Assignees

No one assigned

Labels

area/core kind/bugfix triage/flaky-test

Projects

Backports for 3.27
Status: 3.27.1

Milestone

3.27.1

Development

Successfully merging this pull request may close these issues.

Polyglot application using truffle-enterprise fails due to missing nativebridge artifact in boot.

3 participants

@geoand @gsmet @fedinskiy