Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quasar ext add @quasar/testing-unit-vitest fails to install for TypeScript using npm #384

Open
Abathreixo opened this issue Sep 14, 2024 · 1 comment

Comments

@Abathreixo
Copy link

Software version:

OS: Debian 12
Node: v20.16.0
NPM: 10.8.3
Any other software related to your bug: No

What did you get as the error?

npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: [email protected]
npm error Found: @types/[email protected]
npm error node_modules/@types/node
npm error @types/node@"" from @types/[email protected]
npm error node_modules/@types/body-parser
npm error @types/body-parser@"
" from @types/[email protected]
npm error node_modules/@types/express
npm error @types/express@"^4.17.13" from @quasar/[email protected]
npm error node_modules/@quasar/app-vite
npm error dev @quasar/app-vite@"^1.9.0" from the root project
npm error 1 more (@types/compression)
npm error @types/node@"" from @types/[email protected]
npm error node_modules/@types/connect
npm error @types/connect@"
" from @types/[email protected]
npm error node_modules/@types/body-parser
npm error @types/body-parser@"" from @types/[email protected]
npm error node_modules/@types/express
npm error @types/express@"^4.17.13" from @quasar/[email protected]
npm error node_modules/@quasar/app-vite
npm error 1 more (@types/compression)
npm error 4 more (@types/express-serve-static-core, @types/send, ...)
npm error
npm error Could not resolve dependency:
npm error peerOptional @types/node@"^18.0.0 || >=20.0.0" from [email protected]
npm error node_modules/vitest
npm error peer vitest@"^1.1.0 || ^2.0.0" from @quasar/[email protected]
npm error node_modules/@quasar/quasar-app-extension-testing-unit-vitest
npm error dev @quasar/quasar-app-extension-testing-unit-vitest@"
" from the root project
npm error
npm error Conflicting peer dependency: @types/[email protected]
npm error node_modules/@types/node
npm error peerOptional @types/node@"^18.0.0 || >=20.0.0" from [email protected]
npm error node_modules/vitest
npm error peer vitest@"^1.1.0 || ^2.0.0" from @quasar/[email protected]
npm error node_modules/@quasar/quasar-app-extension-testing-unit-vitest
npm error dev @quasar/quasar-app-extension-testing-unit-vitest@"*" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /home/user/.npm/_logs/2024-09-14T16_07_45_245Z-eresolve-report.txt
npm error A complete log of this run can be found in: /home/user/.npm/_logs/2024-09-14T16_07_45_245Z-debug-0.log

App • ⚠️ Command "npm" failed with exit code: 1

App • ⚠️ FAIL Failed to install @quasar/quasar-app-extension-testing-unit-vitest

What were you expecting?

The quasar extension to install

What steps did you take, to get the error?

  1. npm create quasar
  2. Choose TypeScript (use the default values for the rest)
  3. cd quasar-project
  4. quasar ext add @quasar/testing-unit-vitest

Additional note: if using pnpm (version 9.9.0), the installation will be successful, but then the command: "quasar dev" loads the default page and then proceeds to throw errors.

@IlCallo
Copy link
Member

IlCallo commented Sep 16, 2024

There are 2 problems here
The first one is that @quasar/app-vite installs an old version of @types/node, and we can easily fix it

The second one is that Vitest 2 requires Vite 5 and I kind of missed that requirement when I added Vitest 2 support
As a first side effect, some typings aren't compatible and generate TS errors in vitest.config.ts
The solution for this is a bit tricky, we need to detect which version of @quasar/app-vite or vite is currently used and install Vitest 1 or Vitest 2 depending on the available one

Thanks for reporting, I hope I'll be able to fix this next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants