Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make initiator clear in connection_started #119

Open
rmarx opened this issue Oct 31, 2020 · 0 comments
Open

Make initiator clear in connection_started #119

rmarx opened this issue Oct 31, 2020 · 0 comments

Comments

@rmarx
Copy link
Contributor

rmarx commented Oct 31, 2020

Currently, connection_started utilizes src_ip and dst_ip (and equivalent for ports), where the intended meaning is that src means the initiator (typically client) and dst the server.

However, this is a) unclear and b) it does not allow deducing what the "local" ip is for where this trace was captured without correlating client/server with the vantagepoint (and if that vantagepoint is network, it becomes more murky).

Some options for solving:

  1. rename fields to local_ip and remote_ip
  2. add initiator field (e.g., with values 'local' and 'peer')
  3. completely revise how we log paths/IPs and potentially decouple from connection_started (also good in terms of privacy, migration, multipath, ...).

Option 3 is probably best, should revisit when properly fixing migration in qlog (see also #79 and #57)

cc @marten-seemann

@rmarx rmarx added the future-versions issue will be tackled but not for the current iteration label Oct 31, 2020
@rmarx rmarx self-assigned this Aug 18, 2021
@rmarx rmarx added current-version design quic-http3-fields privacy and removed future-versions issue will be tackled but not for the current iteration labels Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant