-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger for H3PriorityUpdated #324
Comments
Personally, I don't think I'd have the ability to pass through enough context to my logging library to capture the trigger. But I think I need a bit more time to work on the implementation. |
@LPardue any update on your opinion on this? I still think this would be useful in general, even if quiche can't pass it :) and i still like the values I proposed above. Are you opposed to a PR for this? |
I can live with it if you want to add it. But I'd like a better description of how the "trigger" field is a part of event data; see #429 |
Thinking on this some more, I don't think the values in the OP are actually a trigger. They are a result of applying the guidance in https://www.rfc-editor.org/rfc/rfc9218.html#name-merging-client-and-server-d. In other words, how the value of So I think what maybe what you want is an optional Then if you want a |
I am wondering if the new H3PriorityUpdated event (see #312) needs some specified
trigger
field values.Conceptually, you can get the necessary context from other events surrounding this event (e.g., if you get a H3FrameParsed with a HEADERS containing a
priority
field preceding this, that's a clear indicator that's the trigger). However, there are cases where this is less clear (e.g., default initialization to a value different from the spec, local override due to configuration or other logic, merging of client and server-sent priorities for the same stream, ...)We don't NEED to define any triggers here (
trigger
is always defined on event data, just not necessarily specced in qlog), but I'm wondering if some default values would be useful here @LPardue?e.g.,
The text was updated successfully, but these errors were encountered: