feat: Import rlang types-check standalone and implement improvements #433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… improvements Import comprehensive type checking functions from rlang standalone and apply them throughout the DBItest codebase to improve argument validation and error handling. ## Changes ### New Files - Add `R/import-standalone-types-check.R` with 20+ type checking functions - Add `R/import-standalone-obj-type.R` with supporting object type utilities ### Enhanced Type Validation - `context.R`: Add validation for `set_as_default` (bool), `name` (string, nullable), `default_skip` (character vector, nullable) - `run.R`: Add validation for `skip` (character, nullable), `run_only` (character, nullable), `test_suite` (string) - `spec-meta-bind-.R`: Add validation for `requires_names` (bool, nullable), `placeholder_fun` (character/function) - `utils.R`: Enhanced `check_df()` to use `check_data_frame()` for better error messages ## Benefits - More informative error messages with automatic argument context - Consistent validation patterns and error handling - Built-in flexibility with `allow_null`, `allow_na` options - Enhanced user experience with clearer type guidance 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Kirill Müller <[email protected]>
|
CC @moodymudskipper. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import comprehensive type checking functions from rlang standalone and apply them throughout the DBItest codebase to improve argument validation and error handling.
Changes
New Files
R/import-standalone-types-check.Rwith 20+ type checking functionsR/import-standalone-obj-type.Rwith supporting object type utilitiesEnhanced Type Validation
context.R: Add validation forset_as_default(bool),name(string, nullable),default_skip(character vector, nullable)run.R: Add validation forskip(character, nullable),run_only(character, nullable),test_suite(string)spec-meta-bind-.R: Add validation forrequires_names(bool, nullable),placeholder_fun(character/function)utils.R: Enhancedcheck_df()to usecheck_data_frame()for better error messagesBenefits
allow_null,allow_naoptionsCloses #432
🤖 Generated with Claude Code