From ead2965cec0c98e602c23c3fcaf260a6a5e7124a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kirill=20M=C3=BCller?= Date: Sun, 26 Sep 2021 07:31:51 +0200 Subject: [PATCH] NEWS and CRAN comments --- NEWS.md | 42 ++++++++++++++++-------------------------- cran-comments.md | 14 ++++---------- 2 files changed, 20 insertions(+), 36 deletions(-) diff --git a/NEWS.md b/NEWS.md index 6221ab24..530e2f71 100644 --- a/NEWS.md +++ b/NEWS.md @@ -2,44 +2,34 @@ # RPostgres 1.4.0 (2021-09-25) -- Same as previous version. - - -# RPostgres 1.3.3.9003 (2021-09-25) +## Features +- `Redshift()` connections now adhere to almost all of the DBI specification when connecting to a Redshift cluster. BLOBs are not supported on Redshift, and there are limitations with enumerating temporary and persistent tables (#215, #326). - `dbBegin()`, `dbCommit()` and `dbRollback()` gain `name` argument to support savepoints. An unnamed transaction must be started beforehand (#13). -- `dbSendQuery()` uses single dispatch (#320). - `dbSendQuery()` gains `immediate` argument. Multiple queries (separated by semicolons) can be passed in this mode, query parameters are not supported (#272). - `dbConnect(check_interrupts = TRUE)` now aborts a running query faster and more reliably when the user signals an interrupt, e.g. by pressing Ctrl+C (#336). -- `dbQuoteLiteral()` uses single dispatch and switchpatching (#320). - +- `dbAppendTable()` gains `copy` argument. If set to `TRUE`, data is imported via `COPY name FROM STDIN` (#241, @hugheylab). +- Postgres `NOTICE` messages are now forwarded as proper R messages and can be captured and suppressed (#208). +- `dbWriteTable()` uses a transaction (#307). -# RPostgres 1.3.3.9002 (2021-09-15) -- Document when `field.types` is used in `dbWriteTable()` (#206). -- Document setting the tablespace before writing a table (#246). -- Tweak error message for named `params` argument to `dbBind()` (#266). -- `Redshift()` connections now adhere to almost all of the DBI specification when connecting to a Redshift cluster. BLOBs are not supported on Redshift, and there are limitations with enumerating temporary tables (#215). +## Bug fixes +- `dbQuoteLiteral()` converts timestamp values to input time zone, used when writing tables to Redshift (#325). -# RPostgres 1.3.3.9001 (2021-09-13) +## Internal -- `dbExistsTable()`, `dbListTables()` and `dbListObjects()` now work for Redshift, with the limitation that only the topmost tables on the search path are returned (#215, #326). -- `dbWriteTable()` and `dbAppendTable()` default to `copy = NULL`, this translates to `TRUE` for `Postgres()` and `FALSE` for `Redshift()` connections (#329). -- `dbAppendTable()` quotes values only once for Redshift (#328). -- `dbQuoteString()` uses custom quoting routine for Redshift (#327). -- `dbQuoteLiteral()` converts timestamp values to input time zone (#325). -- `dbWriteTable()` uses a transaction (#307). -- `dbAppendTable()` gains `copy` argument, `TRUE` by default. If set, data is imported via `COPY name FROM STDIN` (#241, @hugheylab). -- Order help topics on pkgdown site. -- Use `@examplesIf` in method documentation. - Skip timestamp tests on i386 (#318). -- Postgres `NOTICE` messages are now forwarded as proper R messages and can be captured and suppressed (#208). - +- `dbSendQuery()` and `dbQuoteLiteral()` use single dispatch (#320). +- `dbWriteTable()` and `dbAppendTable()` default to `copy = NULL`, this translates to `TRUE` for `Postgres()` and `FALSE` for `Redshift()` connections (#329). -# RPostgres 1.3.3.9000 (2021-07-05) +## Documentation -- Same as previous version. +- Order help topics on pkgdown site. +- Use `@examplesIf` in method documentation. +- Document when `field.types` is used in `dbWriteTable()` (#206). +- Document setting the tablespace before writing a table (#246). +- Tweak error message for named `params` argument to `dbBind()` (#266). # RPostgres 1.3.3 (2021-07-05) diff --git a/cran-comments.md b/cran-comments.md index 0106d054..0bd24082 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -2,21 +2,15 @@ RPostgres 1.4.0 ## Cran Repository Policy -- [ ] Reviewed CRP last edited 2021-09-25. - -See changes at https://github.com/eddelbuettel/crp/compare/master@%7B2021-04-25%7D...master@%7B2021-09-25%7D +- [x] Reviewed CRP last edited 2021-09-25. ## R CMD check results - [x] Checked locally, R 4.1.1 -- [ ] Checked on CI system, R 4.1.1 -- [ ] Checked on win-builder, R devel - -Check the boxes above after successful execution and remove this line. Then run `fledge::release()`. +- [x] Checked on CI system, R 4.1.1 +- [x] Checked on win-builder, R devel ## Current CRAN check results - [x] Checked on 2021-09-25, problems found: https://cran.r-project.org/web/checks/check_results_RPostgres.html -- [ ] NOTE: r-release-macos-arm64, r-release-macos-x86_64, r-release-windows-ix86+x86_64, r-oldrel-macos-x86_64, r-oldrel-windows-ix86+x86_64 - -Check results at: https://cran.r-project.org/web/checks/check_results_RPostgres.html +- [x] NOTE: r-release-macos-arm64, r-release-macos-x86_64, r-release-windows-ix86+x86_64, r-oldrel-macos-x86_64, r-oldrel-windows-ix86+x86_64: large binary