feat: start work on lightswitch #5
Conversation
|
In any case my idea is to fix r-dbi/RSQLite#522 by adding support for pkgdown's dark mode instead of relying on users' machines, if that makes sense. |
|
Thanks. Back then, I picked flatly because it looked nicest to me. I can't contribute much here, sorry. We could get support from a specialist if needed. |
|
would you be happy to just go with the default pkgdown theme or do you want to customize anything right now? If we go with the default theme, we can add the light switch and solve that user's issue. |
|
I don't follow, flatly has a light switch: https://bootswatch.com/flatly/ . |
|
The thing is, the light switch from pkgdown does not work with themes (yet?). "(Themes are unlikely to work with the light switch, but you can try it and see.)" in https://pkgdown.r-lib.org/articles/customise.html#bootswatch-themes (I did try and did see 😁 ) |
|
actually maybe it's undocumented but a bit better than I thought, let me try something. |
|
ah no but I'll open an issue. |
Themes don't work with the lightswitch (r-lib/pkgdown#2679 + I tried it here and the light theme looked awful).
From the Bootswatch flatly theme, @krlmlr what would you say defines the R-DBI "visual identity"? I know we kept https://r-dbi.org/ pretty close to the defaults.