Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dry run adds space if url contains colon #567

Open
hadley opened this issue Oct 18, 2024 · 0 comments · May be fixed by #607
Open

Dry run adds space if url contains colon #567

hadley opened this issue Oct 18, 2024 · 0 comments · May be fixed by #607
Labels
bug an unexpected problem or unintended behavior
Milestone

Comments

@hadley
Copy link
Member

hadley commented Oct 18, 2024

library(httr2)
req_dry_run(request("https://example.com/test:1:2:3"))
#> GET /test: 1:2:3 HTTP/1.1
#> Host: example.com
#> User-Agent: httr2/1.0.5.9000 r-curl/5.2.2 libcurl/8.7.1
#> Accept: */*
#> Accept-Encoding: gzip

Created on 2024-10-18 with reprex v2.1.0

@hadley hadley added the bug an unexpected problem or unintended behavior label Dec 19, 2024
@hadley hadley added this to the v1.1.0 milestone Dec 19, 2024
hadley added a commit that referenced this issue Dec 23, 2024
To make it less likely that URLs (or other non-header contents) are mangled. This only affects verobse printing (including `req_dry_run()`) so it shouldn't cause problems even if it's not 100% accurate.

Fixes #567
@hadley hadley linked a pull request Dec 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant