Version 1.2.0 URL encoding issue with req_url_path_append

[udurraniAtPresage]

Thanks for the quality of life improvements in httr2 version 1.2.0. I see a change in the behaviour of req_url_path_append, and am not sure if that was intended. req_url_path_append returns different results in version 1.1.2 vs 1.2.0 :

library(httr2)

project_id <- "my-proj"

base_url <- "https://firestore.googleapis.com/v1beta1"

path_url <- paste0("projects/", project_id, "/databases/(default)/documents", ":runQuery")

httr2::request(base_url = base_url) |>
  httr2::req_url_path_append(path_url)

Result

# WITH httr2 version 1.1.2
<httr2_request>
  GET https://firestore.googleapis.com/v1beta1/projects/my-proj/databases/(default)/documents:runQuery
Body: empty


# WITH httr2 version 1.2.0
<httr2_request>
  GET https://firestore.googleapis.com/v1beta1/projects/my-proj/databases/%28default%29/documents%3ArunQuery
Body: empty

Is this a bug or expected behaviour?

[hadley]

This is happening because we switched to using curl's url parsing/modifying code, and it is stricter than httr2's previous code. I'm not sure if this is a feature or a bug, but google in particularly seems to use colons in URLs a lot, and won't accept escaped colons (which we're pretty sure it should). So we'll probably try and roll this back in the near future.

[udurraniAtPresage]

Thanks! I'll hold on to making any changes for now. Looking forward to the roll back.