Secrets are deleted when unchecking 'Remember with keyring' in `rstudioapi::askForSecret()`

[nwstephens]

Cross posting this to rstudio/rstudioapi#226, because it's hard to tell if the issue is with the rstudioapi package or the keyring package.

[nwstephens]

This issue occurs with the current rstudioapi and keyring packages on CRAN. When a user unchecks the box Remember with keyring it also deletes the secret from the keyring. This is unexpected, especially now that askForPassword calls askForSecret. I would not expect the secret to be deleted when unchecking the box. Instead, I would expect to return the password and leave the secret in the keychain (in essence, I would expect to fall back to askForPassword).

[nwstephens]

This also raises the question of how to delete secrets in the keyring. From the console, I would just run key_delete(). With the dialogs, you could prompt the user to delete the secret when the entering a NULL value in the input window -- but I personally don't think that's necessary. Until there is a more complete UX for managing secrets in the IDE, I think issuing key_delete() is sufficient for deleting secrets.

[gaborcsardi]

I am fairly sure that this is not an issue with keyring, and it does not delete keys unless you explicitly call key_delete()

But please reopen if you think I am wrong.