Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing <NA> in deprecation warning #148

Open
rjake opened this issue Nov 30, 2022 · 2 comments
Open

Showing <NA> in deprecation warning #148

rjake opened this issue Nov 30, 2022 · 2 comments

Comments

@rjake
Copy link

rjake commented Nov 30, 2022

In the examples and my own code, I see <NA> in the output
https://lifecycle.r-lib.org/reference/deprecate_soft.html#ref-examples

deprecate_warn("1.0.0", "foo()")
#> Warning: `foo()` was deprecated in <NA> 1.0.0.

I think it's not finding the pkg argument

glue_what("{ fn } was deprecated in { pkg } { when }.")

@lionel-
Copy link
Member

lionel- commented Dec 1, 2022

It will be detected once used from a function that lives in a package namespace. We could add an info bullet about this.

The other way you can provide the info is by supplying "pkg::foo()" instead of "foo()".

@hadley
Copy link
Member

hadley commented Nov 2, 2023

We might also try a different placeholder than <NA>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants