Revert "lint(text=) finds local settings again"

This reverts commit b548c78.

Author: MichaelChirico

NEWS.md

@@ -16,7 +16,7 @@
 ## Bug fixes
 
 * `Lint()`, and thus all linters, ensures that the returned object's `message` attribute is consistently a simple character string (and not, for example, an object of class `"glue"`; #2740, @MichaelChirico).
-* Files with encoding inferred from settings read more robustly under `lint(parse_settings = TRUE)` (#2803, @MichaelChirico). Thanks also to @bastistician for detecting a regression caused by the initial change for users of Emacs (#2847).
+* Files with encoding inferred from settings read more robustly under `lint(parse_settings = TRUE)` (#2803, @MichaelChirico).
 
 ## Changes to default linters
 

R/lint.R

@@ -45,8 +45,9 @@ lint <- function(filename, linters = NULL, ..., cache = FALSE, parse_settings =
 
   needs_tempfile <- missing(filename) || re_matches(filename, rex(newline))
   inline_data <- !is.null(text) || needs_tempfile
+  parse_settings <- !inline_data && isTRUE(parse_settings)
 
-  if (isTRUE(parse_settings)) {
+  if (parse_settings) {
     read_settings(filename)
     on.exit(reset_settings(), add = TRUE)
   }

R/settings.R

@@ -65,7 +65,6 @@
 read_settings <- function(filename, call = parent.frame()) {
   reset_settings()
 
-  if (missing(filename)) filename <- "./any_local_file"
   config_file <- find_config(filename)
   default_encoding <- find_default_encoding(filename)
   if (!is.null(default_encoding)) {

tests/testthat/test-lint.R

@@ -233,11 +233,3 @@ test_that("Linter() input is validated", {
 test_that("typo in argument name gives helpful error", {
   expect_error(lint("xxx", litners = identity), "Found unknown arguments in `...`: `litners`")
 })
-
-test_that("settings are picked up under lint(text=)", {
-  .lintr <- withr::local_tempfile(lines = "linters: list(assignment_linter())")
-  withr::local_options(lintr.linter_file = .lintr)
-
-  # lint '=', but not the operator spacing
-  expect_length(lint(text = "a=1"), 1L)
-})