Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not build vignettes for GH packages by default #71

Open
gaborcsardi opened this issue Nov 11, 2018 · 6 comments
Open

Do not build vignettes for GH packages by default #71

gaborcsardi opened this issue Nov 11, 2018 · 6 comments

Comments

@gaborcsardi
Copy link
Member

Maybe? And have an option for all packages.

@jimhester jimhester added the feature a feature request or enhancement label Aug 18, 2020
@e-kotov
Copy link

e-kotov commented Aug 23, 2024

I don't see {pak} building vignettes when install from GitHub at all. Whenever I install a package from GitHub using {pak}, there are no vignettes after the installation. And I could not find an argument in any of {pak}'s functions to control that.

@gaborcsardi
Copy link
Member Author

IDK why this is not documented, but you need to set the PKG_BUILD_VIGNETTES=true env var, or potentially the pkg.build_vignettes = TRUE option also works.

@gaborcsardi gaborcsardi added documentation and removed feature a feature request or enhancement labels Aug 23, 2024
@e-kotov
Copy link

e-kotov commented Aug 23, 2024

Thanks for the tips!

or potentially the pkg.build_vignettes = TRUE option also works.

returns unused argument (pkg.build_vignettes = TRUE)

And that's to be expected, as pkg_install() does not have the ... argument, so it will just refuse anything not listed.

PKG_BUILD_VIGNETTES=true

Sys.setenv(PKG_BUILD_VIGNETTES=TRUE)

That works!

@e-kotov
Copy link

e-kotov commented Aug 23, 2024

@gaborcsardi out of curiosity, how does Sys.setenv(PKG_BUILD_VIGNETTES=TRUE) magically works, if the package source does not have any code that would read this env var? At least I am failing to find it.

@gaborcsardi
Copy link
Member Author

returns unused argument (pkg.build_vignettes = TRUE)

It is an option, so do options(pkg.build_vignettes = TRUE).

if the package source does not have any code that would read this env var?

@e-kotov
Copy link

e-kotov commented Aug 23, 2024

It is an option, so do options(pkg.build_vignettes = TRUE)

Ahhh! thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants