Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add robustness to repo source not having a slash #2017

Closed
maelle opened this issue Jan 17, 2022 · 3 comments · Fixed by #2481
Closed

Add robustness to repo source not having a slash #2017

maelle opened this issue Jan 17, 2022 · 3 comments · Fixed by #2481
Labels
feature a feature request or enhancement linking 📎

Comments

@maelle
Copy link
Collaborator

maelle commented Jan 17, 2022

In

paste0(url$source, paths)
if one has e.g.

repo:
  url:
    home: https://gitlab.com/chuxinyuan/ecce
    source: https://gitlab.com/chuxinyuan/ecce/-/tree/master

without "/" the links to code source are wrong as they are, well, missing a slash.

Sort of related to #2015

@hadley hadley added feature a feature request or enhancement linking 📎 labels May 31, 2022
@chuxinyuan
Copy link

Sorry, I was unable to access github for a long time. This issue seems to have received little attention. If necessary, I would like to cooperate with you to complete the development and testing work.

@hadley
Copy link
Member

hadley commented Apr 19, 2024

Since we already have a fs dependency, I think we can just switch to fs::path() here.

@hadley
Copy link
Member

hadley commented Apr 22, 2024

Ah that doesn't work because it strips the double // from http://

hadley added a commit that referenced this issue Apr 22, 2024
hadley added a commit that referenced this issue Apr 23, 2024
SebKrantz pushed a commit to SebKrantz/pkgdown that referenced this issue Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement linking 📎
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants