Skip to content

CleanupReporter does not error if tests fail #163

@jeroen

Description

@jeroen

The av package uses this:

reporter <- ps::CleanupReporter(testthat::CheckReporter)$new(proc_cleanup = FALSE, proc_fail = FALSE, conn_fail = FALSE)
test_check("av", reporter = reporter)

However test failures have gone unnoticed because this does not error if the tests fail.

For example see: https://github.com/ropensci/av/actions/runs/10263707793 (you can see there is a test error for macos-latest in the GHA annotations or artifacts but the check still says ✅ )

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugan unexpected problem or unintended behavior

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions