Skip to content

Checking for missing S3 method exports hangs "forever" if you have large data objects in the package #1593

Closed
@jranke

Description

@jranke
Contributor

In package yet unpublished I have a large data object (the .rda file has about 6 MB). With current roxygen versions, the namespace roclet hangs here

https://github.com/r-lib/roxygen2/blob/main/R/namespace.R#L402

This is apparently very inefficient if you have large objects in s3objects. If I remove the data object from the package, namespace generation proceeds swiftly as usual.

Activity

added a commit that references this issue on Feb 9, 2024
30a4595
alexpghayes

alexpghayes commented on Mar 28, 2024

@alexpghayes

I'm running into this as well with https://github.com/alexpghayes/latentnetmediate and it's pretty debilitating. Downgrading to version 7.2.0 resolved my issue temporarily.

Edit: #1594 also resolves my issue. Thanks!

added a commit that references this issue on Apr 1, 2024
jranke

jranke commented on Apr 23, 2024

@jranke
ContributorAuthor

Hi, I wonder if noone with commit rights for roxygen is affected by this bug? What about @krlmlr or @DavisVaughan , could you maybe have a look?

gravesti

gravesti commented on Jul 1, 2024

@gravesti

I was hoping this fix would make it into this latest release. To help demonstrate for any reviewers the problem, with my package which has a few moderately large example data sets but all .rda < 1MB.

with 7.3.2:

> system.time({roxygen2::roxygenise()})
ℹ Loading TrialEmulation
   user  system elapsed 
272.816   0.445 274.110 

with the proposed fix in #1593 :

> system.time({roxygen2::roxygenise()})
ℹ Loading TrialEmulation
   user  system elapsed 
  5.187   0.156   2.700 
added a commit that references this issue on Jul 10, 2024
7c12664
added a commit that references this issue on Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @jranke@alexpghayes@gravesti

      Issue actions

        Checking for missing S3 method exports hangs "forever" if you have large data objects in the package · Issue #1593 · r-lib/roxygen2