Skip to content

compare_proxy method for ignoring the storage mode of Date,POSIXct #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

compare_proxy method for ignoring the storage mode of Date,POSIXct #216

wants to merge 2 commits into from

Conversation

MichaelChirico
Copy link
Contributor

Closes #215

@MichaelChirico
Copy link
Contributor Author

I can update the snapshots later if this is deemed a good fit.

@hadley
Copy link
Member

hadley commented Jul 7, 2025

It feels to me like we already handle this because expect_identical() requires them to be the same type, but expect_equal() just requires them to have the same value.

@hadley
Copy link
Member

hadley commented Jul 7, 2025

Closing it here, but happy to continue discussion in the issue.

@hadley hadley closed this Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggested improvement for "looser" storage rules of Date,POSIXct in R>=4.5.0
2 participants
@MichaelChirico @hadley