You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've started looking at the guide to porting from GTK 3 to GTK 4. A lot of it seems fairly straightforward, but I see some challenges around this point:
Set a proper application ID
In GTK 4 we want the application’s GApplication ‘application-id’ (and therefore the D-Bus name), the desktop file basename and Wayland’s xdg-shell app_id to match. In order to achieve this with GTK 3.x call g_set_prgname() with the same application ID you passed to GtkApplication. Rename your desktop files to match the application ID if needed.
The call to g_set_prgname() can be removed once you fully migrated to GTK 4.
Currently, this is what racket/gui passes to gtk_application_new:
It certainly doesn't match the base name of anyone's .desktop file, particularly given the use of gethostname.
There is no guarantee that it will satisfy g_application_id_is_valid, particularly the limit of 255 characters and the restriction to [A-Z][a-z][0-9]_- in labels.
It will never be valid for D-Bus due to the hyphen in org.racket-lang. From the g_application_id_is_valid docs:
Note that the hyphen (-) character is allowed in application identifiers, but is problematic or not allowed in various specifications and APIs that refer to D-Bus, such as Flatpak application IDs, the DBusActivatable interface in the Desktop Entry Specification, and the convention that an application’s “main” interface and object path resemble its application identifier and bus name. To avoid situations that require special-case handling, it is recommended that new application identifiers consistently replace hyphens with underscores.
Like D-Bus interface names, application identifiers should start with the reversed DNS domain name of the author of the interface (in lower-case), and it is conventional for the rest of the application identifier to consist of words run together, with initial capital letters.
As with D-Bus interface names, if the author’s DNS domain name contains hyphen/minus characters they should be replaced by underscores, and if it contains leading digits they should be escaped by prepending an underscore. For example, if the owner of 7-zip.org used an application identifier for an archiving application, it might be named org._7_zip.Archiver.
These rules would suggest something like org.racket_lang.DrRacket.
More broadly, it seems like the application ID should be under the control of the programmer.
I'm not sure how best to communicate the application ID to the point where it's needed. Maybe it could us one of the special command-line options to gracket that translate to unsafe-register-process-global? (Or maybe some existing one should be used?)
Then there's the aspect of getting the .desktop file installed under the corresponding name, particularly for something like DrRacket where we have, and presumably want to keep:
which implies that we continue to use the name drracket.desktop to work with get-aux-from-path. Maybe we should add another kind of aux entry to specify the application ID, and use that when installing the file? Maybe there's something analogous to the rewriting make-gracket-launcher already does to the Exec entry in the .desktop file.
The text was updated successfully, but these errors were encountered:
I've started looking at the guide to porting from GTK 3 to GTK 4. A lot of it seems fairly straightforward, but I see some challenges around this point:
Currently, this is what
racket/gui
passes togtk_application_new
:gui/gui-lib/mred/private/wx/gtk/unique.rkt
Lines 158 to 172 in ba3b19b
There are several problems:
It certainly doesn't match the base name of anyone's
.desktop
file, particularly given the use ofgethostname
.There is no guarantee that it will satisfy
g_application_id_is_valid
, particularly the limit of 255 characters and the restriction to[A-Z][a-z][0-9]_-
in labels.It will never be valid for D-Bus due to the hyphen in
org.racket-lang
. From theg_application_id_is_valid
docs:These rules would suggest something like
org.racket_lang.DrRacket
.More broadly, it seems like the application ID should be under the control of the programmer.
I'm not sure how best to communicate the application ID to the point where it's needed. Maybe it could us one of the special command-line options to
gracket
that translate tounsafe-register-process-global
? (Or maybe some existing one should be used?)Then there's the aspect of getting the
.desktop
file installed under the corresponding name, particularly for something like DrRacket where we have, and presumably want to keep:https://github.com/racket/drracket/blob/0291c0ebac7d098e827c063a4ffeaa4c2b77d80d/drracket/drracket/info.rkt#L9-L10
which implies that we continue to use the name
drracket.desktop
to work withget-aux-from-path
. Maybe we should add another kind of aux entry to specify the application ID, and use that when installing the file? Maybe there's something analogous to the rewritingmake-gracket-launcher
already does to theExec
entry in the.desktop
file.The text was updated successfully, but these errors were encountered: