Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ergonomics of delete op #49

Open
kuy opened this issue Jul 9, 2020 · 0 comments
Open

Improve ergonomics of delete op #49

kuy opened this issue Jul 9, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@kuy
Copy link
Collaborator

kuy commented Jul 9, 2020

Is your feature request related to a problem? Please describe.

delete op return Ok even if given key is not found. This is not a bug, it's an idempotent operation. That said, I was surprised really.

Describe the solution you'd like

Some options:

  • rename it to delete_if_exist
  • return an error if not exist
  • hybrid of above two: provide delete_if_exist op and delete op which return an error

Describe alternatives you've considered

N/A

Additional context

https://docs.aws.amazon.com/amazondynamodb/latest/APIReference/API_DeleteItem.html

@bokuweb bokuweb added the enhancement New feature or request label Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants