Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behavior of retried jobs #181

Open
salmonsteak1 opened this issue Oct 25, 2024 · 1 comment
Open

Behavior of retried jobs #181

salmonsteak1 opened this issue Oct 25, 2024 · 1 comment

Comments

@salmonsteak1
Copy link

I just came across this issue #78 as I was confused by the behavior of failed jobs in mission control and decided to search for related issues.

Right now, it seems like jobs that are using the retry_on mechanism by active job would generate multiple entries under "finished job", with the final failed attempt under "failed jobs". Since they all have the same active job ID, they would point to the same entry under the hood.

I was just wondering if that's really the intended case as I was initially under the impression that my failed job was somehow being completed successfully since it was under the "finished jobs" tab too.

@rosa
Copy link
Member

rosa commented Oct 29, 2024

Hey @salmonsteak1, for Solid Queue, yes, that's the intended behaviour because it's what Active Job does when it retries a job automatically: it just enqueues it again with the same Job ID.

We could show this more clearly in Mission Control, though 🤔 Perhaps adding some more prominent indication that the finished job has been retried? However, I'm not sure if it's possible to know when a job has been retried and has finished fine because the exception raised has been handled by Active Job, or if it has actually finished for real. All this happens outside Solid Queue. Resque handles this differently because it doesn't keep finished jobs around, it just deletes jobs when picking them up from the queue, so this doesn't happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants