Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SolidQueue's tests Vs. my local environment #400

Open
hms opened this issue Nov 2, 2024 · 2 comments
Open

SolidQueue's tests Vs. my local environment #400

hms opened this issue Nov 2, 2024 · 2 comments

Comments

@hms
Copy link
Contributor

hms commented Nov 2, 2024

I'm about ready to push a PR to address resource constrained deployments.

As part of testing my PR I'm finding the tests have some issues and if they are known issues and not limited to my environment I'd like to include with the PR. What I'm seeing:

  • There are several tests generate a "RuntimeError: everything is broken", although the tests report as passing. I'm pretty sure this is due to a Stubbed object not allowing a method and AppExcutor.handle_thread_error "getting involved" in a way that allows the exception to not fail the test.
  • There are several tests generate various broken pipe errors in Interruptible.rb. I've got code that handles all of the errors that I've encountered.

I'm running on a M series MacBookPro. PostgreSQL and MySQL are running in docker as configured via bin/setup. I have not made any other changes or adjustments to the environment.

Are these known issues that I should include in my PR or yet another case of "it's just me?"

@hms
Copy link
Contributor Author

hms commented Nov 9, 2024

Adding to my confusion is .ruby-version is set at: 3.3.1, but the GitHub actions use ruby: 3.3.5.

What is the development standard for SolidQueue so I can match the expected requirements?

@rosa
Copy link
Member

rosa commented Nov 9, 2024

Oops, so sorry I haven't responded yet to this, I missed the notification last week!

There are several tests generate a "RuntimeError: everything is broken", although the tests report as passing.

Yes! This is expected, the error is raised on purpose. Setting Thread.report_on_exception = false prevents these from showing up at all in some cases but not all.

There are several tests generate various broken pipe errors in Interruptible.rb.

Huh, I haven't encountered those, but perhaps it's been by chance. I'm very curious to know what are the fixes.

Adding to my confusion is .ruby-version is set at: 3.3.1, but the GitHub actions use ruby: 3.3.5.

Ah, this is an oversight. Any of them should work, feel free to change .ruby-version to match GitHub actions if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants