Skip to content

Commit afee74e

Browse files
committed
Remove unused code in Dragonfly field
1 parent 34c5fec commit afee74e

File tree

3 files changed

+24
-1
lines changed

3 files changed

+24
-1
lines changed

lib/rails_admin/config/fields/types/dragonfly.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ class Dragonfly < RailsAdmin::Config::Fields::Types::FileUpload
1212
RailsAdmin::Config::Fields::Types.register(self)
1313

1414
register_instance_option :image? do
15-
false unless value
1615
if abstract_model.model.new.respond_to?("#{name}_name")
1716
mime_type = Mime::Type.lookup_by_extension(bindings[:object].send("#{name}_name").to_s.split('.').last)
1817
mime_type.to_s.match?(/^image/)

spec/fixtures/test.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
test

spec/rails_admin/config/fields/types/drangonfly_spec.rb

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,29 @@
55
RSpec.describe RailsAdmin::Config::Fields::Types::Dragonfly do
66
it_behaves_like 'a generic field type', :string_field, :dragonfly
77

8+
let(:field) do
9+
RailsAdmin.config('FieldTest').fields.detect do |f|
10+
f.name == :dragonfly_asset
11+
end.with(object: record)
12+
end
13+
14+
describe '#image?' do
15+
let(:file) { File.open(file_path('test.jpg')) }
16+
let(:record) { FactoryBot.create :field_test, dragonfly_asset: file }
17+
18+
it 'returns true' do
19+
expect(field.image?).to be true
20+
end
21+
22+
context 'with non-image' do
23+
let(:file) { File.open(file_path('test.txt')) }
24+
25+
it 'returns false' do
26+
expect(field.image?).to be false
27+
end
28+
end
29+
end
30+
831
describe 'with a model which does not extend Dragonfly::Model' do
932
before do
1033
class NonDragonflyTest < Tableless

0 commit comments

Comments
 (0)