-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chalkboard] Annotations not showing up on PDF printout #97
Comments
Thanks for reporting this issue. Apparently, there was a bigger problem with compatibility to reveal.js 4. I just pushed a fix 8127033 that hopefully resolves this issue. Would be nice if you can check whether it works for you as well. Note that only drawings on the chalkboard are added to the printout, drawings on the slides are ignored. |
Hi. Yes, your fix seems to work in my setting: the chalkboard slides are added to the printout! As you mention, the drawings on the slides are still absent, but I assume that fixing this is your next goal... |
Thanks for testing. Actually, ignoring drawings on slides is an intended behaviour for me and I have no plans of including them. However, I would be open to pull requests implementing such a feature. Implementation could be very similar to printouts for chalkboard drawings, however, the canvas needs to be put on top of the slides with the correct scaling. Also this should be made an optional behaviour. |
Then you can update this thread into a feature request, please. Being able to print the drawings on the slides without relying on print screens would be the most useful for me, since I use fillable slides for teaching. Thanks a lot! |
This patch as an overlay canvas to the generated PDF print version to render the notes added to the slides. To keep the current default behavior, this feature must be enabled by setting the new configuration option "printNotes" to `true`. Unfortunatly the relative positioning between the drawings and the slide content is not perfect since th rendering of the slide content slightly differs in the pdf-print mode. This patch adresses issue rajgoel#97
When loading a presentation with a saved 'chalkboard.json' file, I can see the annotations in presentation mode, but not in PDF-Export mode (adding ?print-pdf to the URL)...
Originally posted by @SapinMalin in #95 (comment)
The text was updated successfully, but these errors were encountered: