use 204 no content for when the spares is not defined #1591

Author: joshdimanteto

src/apiConfigProvider.component.test.tsx

@@ -64,27 +64,6 @@ describe('APIConfigProvider', () => {
     );
   });
 
-  it('settings are loaded (without spares)', async () => {
-    server.use(
-      http.get('/v1/settings/spares-definition', () => {
-        return HttpResponse.json({ system_types: [] }, { status: 200 });
-      })
-    );
-    renderComponent();
-
-    // Preloader is in a loading state when ConfigProvider is
-    // loading the configuration.
-    expect(screen.getByText('Loading...')).toBeInTheDocument();
-
-    await waitFor(() => {
-      expect(screen.queryByText('Loading...')).not.toBeInTheDocument();
-    });
-    expect(screen.getByTestId('settings')).toBeInTheDocument();
-    expect(screen.getByTestId('settings')).toHaveTextContent(
-      JSON.stringify({})
-    );
-  });
-
   it('settings are loaded (without spares 204 no content)', async () => {
     server.use(
       http.get('/v1/settings/spares-definition', () => {

src/catalogue/items/catalogueItemsDetailsPanel.component.test.tsx

@@ -156,7 +156,7 @@ describe('Catalogue Items details panel', () => {
   it('renders details panel correctly (without spares)', async () => {
     server.use(
       http.get('/v1/settings/spares-definition', () => {
-        return HttpResponse.json({ system_types: [] }, { status: 200 });
+        return HttpResponse.json(undefined, { status: 204 });
       })
     );
 

src/catalogue/items/catalogueItemsLandingPage.component.test.tsx

@@ -248,7 +248,7 @@ describe('Catalogue Items Landing Page', () => {
   it('should not display spares number if spares definition is not defined', async () => {
     server.use(
       http.get('/v1/settings/spares-definition', () => {
-        return HttpResponse.json({ system_types: [] }, { status: 200 });
+        return HttpResponse.json(undefined, { status: 204 });
       })
     );
 

src/catalogue/items/catalogueItemsTable.component.test.tsx

@@ -916,7 +916,7 @@ describe('Catalogue Items Table', () => {
   it('renders table correctly (section 1 due to column virtualisation without spares)', async () => {
     server.use(
       http.get('/v1/settings/spares-definition', () => {
-        return HttpResponse.json({ system_types: [] }, { status: 200 });
+        return HttpResponse.json(undefined, { status: 204 });
       })
     );
 

src/items/itemsTable.component.test.tsx

@@ -321,12 +321,9 @@ describe('Items Table', () => {
 
   it('does not display spares definition button when spares is not defined', async () => {
     server.use(
-      http.get<PathParams, DefaultBodyType, SparesDefinition>(
-        '/v1/settings/spares-definition',
-        () => {
-          return HttpResponse.json({ system_types: [] }, { status: 200 });
-        }
-      )
+      http.get('/v1/settings/spares-definition', () => {
+        return HttpResponse.json(undefined, { status: 204 });
+      })
     );
     props.catalogueCategory = getCatalogueCategoryById(
       '9'

src/systems/systemItemsTable.component.test.tsx

@@ -1,7 +1,7 @@
 import { screen, waitFor } from '@testing-library/react';
 import userEvent, { UserEvent } from '@testing-library/user-event';
-import { DefaultBodyType, http, HttpResponse, PathParams } from 'msw';
-import { SparesDefinition, System } from '../api/api.types';
+import { http, HttpResponse } from 'msw';
+import { System } from '../api/api.types';
 import APIConfigProvider from '../apiConfigProvider.component';
 import { server } from '../mocks/server';
 import SystemsJSON from '../mocks/Systems.json';
@@ -78,12 +78,9 @@ describe('SystemItemsTable', () => {
 
   it('renders correctly (without spares)', async () => {
     server.use(
-      http.get<PathParams, DefaultBodyType, SparesDefinition>(
-        '/v1/settings/spares-definition',
-        () => {
-          return HttpResponse.json({ system_types: [] }, { status: 200 });
-        }
-      )
+      http.get('/v1/settings/spares-definition', () => {
+        return HttpResponse.json(undefined, { status: 204 });
+      })
     );
     const view = createView();