-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomerspythonPull requests that update Python codePull requests that update Python code
Description
Considering @joelvdavies's comment here #91 (comment), my suggested changes are as follows:
- Rename
create_presigned_getmethod instores/attachment.pytocreate_presigned_download_url. Download URL to me implies that it would be aGET. - Rename
create_presigned_getinstores/images.pyto something likecreate_presigned_view_url. View URL to me implies that it would be aGET. - Create a new method called
create_presegined_download_urlinstores/images.pythat will generate a presigned URL for downloading images. Download URL to me implies that it would be aGET. - Rename
create_presigned_postmethods instores/attachment.pyandstores/images.pytocreate_presigned_upload_url. Upload URL to me implies that it would be aPOST.
Let me know your thoughts @joelvdavies, @rowan04, @asuresh-code. This can be addressed separately.
Originally posted by @VKTB in #91 (review) (and #94 (comment))
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomerspythonPull requests that update Python codePull requests that update Python code
Type
Projects
Status
Backlog