Skip to content
This repository was archived by the owner on Nov 2, 2023. It is now read-only.

Commit 587f760

Browse files
committed
Fix up nits from review
Signed-off-by: Dan Bason <[email protected]>
1 parent de013e2 commit 587f760

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

pkg/resources/opensearch/config.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ kibanaserver:
5555
description: "Opensearch Dashboards user"
5656
`))
5757

58-
// TODO: investigate alternatives for storing this config. Tidy up and test the cert hostname generati
58+
// TODO: investigate alternatives for storing this config.
5959
defaultConfig = `network.host: 0.0.0.0
6060
plugins.security.ssl.transport.pemcert_filepath: certs/${HOSTNAME}.crt
6161
plugins.security.ssl.transport.pemkey_filepath: certs/${HOSTNAME}.key

pkg/resources/opensearch/workloads.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -335,7 +335,7 @@ func (r *Reconciler) initCertCheckContainer() corev1.Container {
335335
Command: []string{
336336
"bash",
337337
"-c",
338-
"while [ ! -f /usr/share/opensearch/config/certs/${HOSTNAME}.crt ]; do echo 'Waiting for certs'; sleep 5; done",
338+
`while [ ! -f "/usr/share/opensearch/config/certs/${HOSTNAME}.crt" ]; do echo 'Waiting for certs'; sleep 5; done`,
339339
},
340340
VolumeMounts: []corev1.VolumeMount{
341341
certsVolumeMount(),

0 commit comments

Comments
 (0)