Add cert tests

Signed-off-by: Dan Bason <[email protected]>

Author: dbason

controllers/dashboards_controller_test.go

@@ -89,6 +89,17 @@ var _ = Describe("OpensearchCluster Controller", Label("controller"), func() {
 			HaveOwner(dashboards),
 		))
 	})
+	It("should create the secret when tls secret isn't specified", func() {
+		Eventually(Object(&corev1.Secret{
+			ObjectMeta: metav1.ObjectMeta{
+				Name:      "test-dashboards-osdb-tls",
+				Namespace: dashboards.Namespace,
+			},
+		})).Should(ExistAnd(
+			HaveData("tls.crt", nil),
+			HaveData("tls.key", nil),
+		))
+	})
 	It("should update the replica counts", func() {
 		updateObject(dashboards, func(obj *v1beta1.Dashboards) {
 			obj.Spec.Replicas = pointer.Int32(2)
@@ -100,6 +111,32 @@ var _ = Describe("OpensearchCluster Controller", Label("controller"), func() {
 			},
 		})).Should(HaveReplicaCount(2))
 	})
+	It("should not create a secret when tls is specified", func() {
+		secret := &corev1.Secret{
+			ObjectMeta: metav1.ObjectMeta{
+				Name:      "test-tls",
+				Namespace: dashboards.Namespace,
+			},
+			Type: corev1.SecretTypeTLS,
+			StringData: map[string]string{
+				"tls.crt": "this is cert data",
+				"tls.key": "this is key data",
+			},
+		}
+		Expect(k8sClient.Create(context.Background(), secret)).To(Succeed())
+
+		updateObject(dashboards, func(obj *v1beta1.Dashboards) {
+			obj.Spec.TLSSecret = &corev1.LocalObjectReference{
+				Name: secret.Name,
+			}
+		})
+		Eventually(Object(&corev1.Secret{
+			ObjectMeta: metav1.ObjectMeta{
+				Name:      "test-dashboards-osdb-tls",
+				Namespace: dashboards.Namespace,
+			},
+		})).ShouldNot(Exist())
+	})
 	It("should remove the resources when deleted", func() {
 		Expect(k8sClient.Delete(context.Background(), dashboards)).To(Succeed())
 

controllers/opensearchcluster_controller_test.go

@@ -102,6 +102,10 @@ var _ = Describe("OpensearchCluster Controller", Label("controller"), func() {
 					HaveName("internalusers"),
 					HaveVolumeSource("Secret"),
 				)),
+				HaveMatchingVolume(And(
+					HaveName("certs"),
+					HaveVolumeSource("Secret"),
+				)),
 				HaveMatchingContainer(And(
 					HaveName("opensearch"),
 					HaveImage("docker.io/opensearchproject/opensearch:1.0.0"),
@@ -112,6 +116,7 @@ var _ = Describe("OpensearchCluster Controller", Label("controller"), func() {
 					HavePorts("transport", "http", "metrics", "rca"),
 					HaveVolumeMounts("config", "opensearch-data"),
 					HaveVolumeMounts("internalusers", "test-cluster-os-internalusers"),
+					HaveVolumeMounts("certs", "test-cluster-os-certs"),
 				)),
 				HaveMatchingPersistentVolume(And(
 					HaveName("opensearch-data"),
@@ -147,6 +152,7 @@ var _ = Describe("OpensearchCluster Controller", Label("controller"), func() {
 					HavePorts("transport"),
 					HaveVolumeMounts("config", "opensearch-data"),
 					HaveVolumeMounts("internalusers", "test-cluster-os-internalusers"),
+					HaveVolumeMounts("certs", "test-cluster-os-certs"),
 				)),
 				HaveMatchingPersistentVolume(And(
 					HaveName("opensearch-data"),
@@ -156,6 +162,10 @@ var _ = Describe("OpensearchCluster Controller", Label("controller"), func() {
 					HaveName("internalusers"),
 					HaveVolumeSource("Secret"),
 				)),
+				HaveMatchingVolume(And(
+					HaveName("certs"),
+					HaveVolumeSource("Secret"),
+				)),
 			))
 		}()
 		go func() {
@@ -181,12 +191,17 @@ var _ = Describe("OpensearchCluster Controller", Label("controller"), func() {
 					HavePorts("transport", "http", "metrics", "rca"),
 					HaveVolumeMounts("config"),
 					HaveVolumeMounts("internalusers", "test-cluster-os-internalusers"),
+					HaveVolumeMounts("certs", "test-cluster-os-certs"),
 					Not(HaveVolumeMounts("opensearch-data")),
 				)),
 				HaveMatchingVolume(And(
 					HaveName("internalusers"),
 					HaveVolumeSource("Secret"),
 				)),
+				HaveMatchingVolume(And(
+					HaveName("certs"),
+					HaveVolumeSource("Secret"),
+				)),
 			))
 		}()
 		wg.Wait()
@@ -213,6 +228,7 @@ var _ = Describe("OpensearchCluster Controller", Label("controller"), func() {
 		})).Should(ExistAnd(
 			HaveOwner(osCluster),
 			HaveData("logging.yml", nil),
+			HaveData("opensearch.yml", nil),
 		))
 		Eventually(Object(&corev1.Secret{
 			ObjectMeta: metav1.ObjectMeta{
@@ -233,6 +249,17 @@ var _ = Describe("OpensearchCluster Controller", Label("controller"), func() {
 			HaveOwner(osCluster),
 			HaveData("internal_users.yml", nil),
 		))
+		Eventually(Object(&corev1.Secret{
+			ObjectMeta: metav1.ObjectMeta{
+				Name:      "test-cluster-os-pki",
+				Namespace: osCluster.Namespace,
+			},
+		})).Should(ExistAnd(
+			HaveData("transportca.crt", nil),
+			HaveData("transportca.key", nil),
+			HaveData("httpca.crt", nil),
+			HaveData("httpca.key", nil),
+		))
 	})
 	It("should update the replica counts", func() {
 		updateObject(osCluster, func(obj *v1beta1.OpensearchCluster) {