Skip to content
This repository was archived by the owner on Nov 2, 2023. It is now read-only.

Commit ca0d16a

Browse files
authored
Add Github actions CI (#3)
* Add unit tests to actions Signed-off-by: Dan Bason <[email protected]> * Add go module caching to workflow Signed-off-by: Dan Bason <[email protected]> * Add build action Signed-off-by: Dan Bason <[email protected]> * Add go setup to build Signed-off-by: Dan Bason <[email protected]> * Extend timeout Signed-off-by: Dan Bason <[email protected]> * Add validate script Signed-off-by: Dan Bason <[email protected]> * Fix up validate Signed-off-by: Dan Bason <[email protected]> * Update lint settings and fix errors Signed-off-by: Dan Bason <[email protected]> * Separate lint job Signed-off-by: Dan Bason <[email protected]> * Fix spacing Signed-off-by: Dan Bason <[email protected]> * Add checkout to lint Signed-off-by: Dan Bason <[email protected]> * Go mod tidy Signed-off-by: Dan Bason <[email protected]> * Fetch controller-gen Signed-off-by: Dan Bason <[email protected]> * Missing dot in path Signed-off-by: Dan Bason <[email protected]> * Switch publish account Signed-off-by: Dan Bason <[email protected]> * Update permissions for workflow Signed-off-by: Dan Bason <[email protected]> * Finalize ci Signed-off-by: Dan Bason <[email protected]>
1 parent 076c43e commit ca0d16a

File tree

16 files changed

+206
-44
lines changed

16 files changed

+206
-44
lines changed

.github/workflows/build.yaml

+74
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,74 @@
1+
2+
on:
3+
push:
4+
branches:
5+
- main
6+
tags:
7+
- 'v*'
8+
9+
name: Build
10+
11+
jobs:
12+
lint:
13+
runs-on: ubuntu-latest
14+
steps:
15+
- uses: actions/checkout@v2
16+
with:
17+
persist-credentials: false
18+
- uses: golangci/golangci-lint-action@v2
19+
with:
20+
version: v1.42
21+
build:
22+
name: Build and push image
23+
needs: lint
24+
runs-on: ubuntu-latest
25+
permissions:
26+
packages: write
27+
contents: read
28+
steps:
29+
- uses: actions/checkout@v2
30+
with:
31+
persist-credentials: false
32+
- uses: docker/setup-qemu-action@v1
33+
- uses: docker/setup-buildx-action@v1
34+
- uses: docker/login-action@v1
35+
with:
36+
registry: ghcr.io
37+
username: ${{ github.actor }}
38+
password: ${{ secrets.GITHUB_TOKEN }}
39+
- uses: actions/setup-go@v2
40+
with:
41+
go-version: '^1.17'
42+
- uses: actions/cache@v2
43+
with:
44+
path: |
45+
~/.cache/go-build
46+
~/go/pkg/mod
47+
key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
48+
restore-keys: |
49+
${{ runner.os }}-go-
50+
- run: go get sigs.k8s.io/controller-tools/cmd/[email protected]
51+
- run: scripts/build
52+
- run: scripts/validate
53+
- run: cp -r ./bin/manager ./package/
54+
- if: ${{ startsWith(github.ref, 'refs/heads/') }}
55+
uses: docker/build-push-action@v2
56+
with:
57+
context: ./package
58+
file: ./package/Dockerfile
59+
platforms: linux/amd64
60+
push: true
61+
tags: |
62+
ghcr.io/rancher-sandbox/opni-opensearch-operator:latest
63+
- if: ${{ startsWith(github.ref, 'refs/tags/') }}
64+
run: |
65+
echo TAG_NAME=$(echo $GITHUB_REF | sed -e "s|refs/tags/||") >> $GITHUB_ENV
66+
- if: ${{ startsWith(github.ref, 'refs/tags/') }}
67+
uses: docker/build-push-action@v2
68+
with:
69+
context: .
70+
file: ./Dockerfile
71+
platforms: linux/amd64
72+
push: true
73+
tags: |
74+
ghcr.io/rancher-sandbox/opni-opensearch-operator:${{ env.TAG_NAME }}

.github/workflows/test.yaml

+34
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
name: Test
2+
on:
3+
push: {}
4+
pull_request: {}
5+
6+
jobs:
7+
test:
8+
runs-on: ubuntu-latest
9+
steps:
10+
- uses: actions/checkout@v2
11+
with:
12+
persist-credentials: false
13+
- uses: actions/setup-go@v2
14+
with:
15+
go-version: '^1.17'
16+
- uses: actions/cache@v2
17+
with:
18+
path: |
19+
~/.cache/go-build
20+
~/go/pkg/mod
21+
key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
22+
restore-keys: |
23+
${{ runner.os }}-go-
24+
- run: hack/setup-envtest.sh
25+
- run: go test ./... -race -v --ginkgo.label-filter "(unit || controller)"
26+
lint:
27+
runs-on: ubuntu-latest
28+
steps:
29+
- uses: actions/checkout@v2
30+
with:
31+
persist-credentials: false
32+
- uses: golangci/golangci-lint-action@v2
33+
with:
34+
version: v1.42

.gitignore

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ tilt_modules/
2727
tilt-options.yaml
2828
Dockerfile.dapper*
2929
*.DS_Store
30-
**/manager
30+
package/manager
3131

3232
# Distribution/packaging
3333
dist/

.golangci.json

+21
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
{
2+
"linters": {
3+
"disable-all": true,
4+
"enable": [
5+
"govet",
6+
"revive",
7+
"goimports",
8+
"ineffassign",
9+
"gofmt",
10+
"deadcode",
11+
"goerr113",
12+
"goconst"
13+
]
14+
},
15+
"run": {
16+
"skip-files": [
17+
"/zz_generated"
18+
],
19+
"timeout": "10m"
20+
}
21+
}

Dockerfile.dapper

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ ENV DOCKER_VERSION=20.10.5
55
RUN go get sigs.k8s.io/kustomize/kustomize/[email protected] \
66
&& go get sigs.k8s.io/kubebuilder/v3/[email protected] \
77
&& go get sigs.k8s.io/controller-tools/cmd/[email protected] \
8-
&& curl -sL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s v1.38.0 \
8+
&& curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.42.1 \
99
&& apt update \
1010
&& apt -y install jq \
1111
&& curl -sL https://download.docker.com/linux/static/stable/x86_64/docker-${DOCKER_VERSION}.tgz -o docker-${DOCKER_VERSION}.tgz \

config/manager/manager.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ spec:
2727
- /manager
2828
args:
2929
- --leader-elect
30-
image: quay.io/dbason/opni-opensearch-operator:dev
30+
image: ghcr.io/rancher-sandbox/opni-opensearch-operator
3131
name: manager
3232
securityContext:
3333
allowPrivilegeEscalation: false

controllers/suite_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ var (
5252
)
5353

5454
func TestAPIs(t *testing.T) {
55-
SetDefaultEventuallyTimeout(30 * time.Second)
55+
SetDefaultEventuallyTimeout(45 * time.Second)
5656
// SetDefaultEventuallyTimeout(24 * time.Hour) // For debugging
5757
SetDefaultEventuallyPollingInterval(100 * time.Millisecond)
5858
SetDefaultConsistentlyDuration(2 * time.Second)

go.sum

-10
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,6 @@ github.com/alecthomas/template v0.0.0-20190718012654-fb15b899a751/go.mod h1:LOuy
107107
github.com/alecthomas/units v0.0.0-20151022065526-2efee857e7cf/go.mod h1:ybxpYRFXyAe+OPACYpWeL0wqObRcbAqCMya13uyzqw0=
108108
github.com/alecthomas/units v0.0.0-20190717042225-c3de453c63f4/go.mod h1:ybxpYRFXyAe+OPACYpWeL0wqObRcbAqCMya13uyzqw0=
109109
github.com/alecthomas/units v0.0.0-20190924025748-f65c72e2690d/go.mod h1:rBZYJk541a8SKzHPHnH3zbiI+7dagKZ0cgpgrD7Fyho=
110-
github.com/andreyvit/diff v0.0.0-20170406064948-c7f18ee00883 h1:bvNMNQO63//z+xNgfBlViaCIJKLlCJ6/fmUseuG0wVQ=
111110
github.com/andreyvit/diff v0.0.0-20170406064948-c7f18ee00883/go.mod h1:rCTlJbsFo29Kk6CurOXKm700vrz8f0KW0JNfpkRJY/8=
112111
github.com/andybalholm/cascadia v1.0.0/go.mod h1:GsXiBklL0woXo1j/WYWtSYYC4ouU9PqHO0sqidkEA4Y=
113112
github.com/antihax/optional v1.0.0/go.mod h1:uupD/76wgC+ih3iEmQUL+0Ugr19nfwCT1kdvxnR2qWY=
@@ -220,9 +219,7 @@ github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSs
220219
github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
221220
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
222221
github.com/daviddengcn/go-colortext v0.0.0-20160507010035-511bcaf42ccd/go.mod h1:dv4zxwHi5C/8AeI+4gX4dCWOIvNi7I6JCSX0HvlKPgE=
223-
github.com/dbason/logging-operator v0.0.0-20211104200206-ca165c7327da h1:FovJYQQkjDv4mLwkYmpC/CJK7W6oySBMsDdBKB5yk7Q=
224222
github.com/dbason/logging-operator v0.0.0-20211104200206-ca165c7327da/go.mod h1:JcbSQo4reCDpHY5WLv96sY3ISPVd46PMy/geEgBy79g=
225-
github.com/dbason/logging-operator/pkg/sdk v0.0.0-20211104200206-ca165c7327da h1:6o9MklYR10dkdLb4snoS170nVnK0+ByU7KoMulGqWvQ=
226223
github.com/dbason/logging-operator/pkg/sdk v0.0.0-20211104200206-ca165c7327da/go.mod h1:72ynzqFEoKo93T8z7PyfhBxl9gjrpIoc6hFjtucesBI=
227224
github.com/deislabs/oras v0.11.1/go.mod h1:39lCtf8Q6WDC7ul9cnyWXONNzKvabEKk+AX+L0ImnQk=
228225
github.com/denisenkom/go-mssqldb v0.0.0-20191001013358-cfbb681360f0/go.mod h1:xbL0rPBG9cCiLr28tMa8zpbdarY27NDyej4t/EjAShU=
@@ -292,7 +289,6 @@ github.com/fvbommel/sortorder v1.0.1/go.mod h1:uk88iVf1ovNn1iLfgUVU2F9o5eO30ui72
292289
github.com/garyburd/redigo v0.0.0-20150301180006-535138d7bcd7/go.mod h1:NR3MbYisc3/PwhQ00EMzDiPmrwpPxAn5GI05/YaO1SY=
293290
github.com/getsentry/raven-go v0.2.0/go.mod h1:KungGk8q33+aIAZUIVWZDr2OfAEBsO49PX4NzFV5kcQ=
294291
github.com/ghodss/yaml v0.0.0-20150909031657-73d445a93680/go.mod h1:4dBDuWmgqj2HViK6kFavaiC9ZROes6MMH2rRYeMEF04=
295-
github.com/ghodss/yaml v1.0.0 h1:wQHKEahhL6wmXdzwWG11gIVCkOv05bNOh+Rxn0yngAk=
296292
github.com/ghodss/yaml v1.0.0/go.mod h1:4dBDuWmgqj2HViK6kFavaiC9ZROes6MMH2rRYeMEF04=
297293
github.com/globalsign/mgo v0.0.0-20180905125535-1ca0a4f7cbcb/go.mod h1:xkRDCp4j0OGD1HRkm4kmhM+pmpv3AKq5SU7GMg4oO/Q=
298294
github.com/globalsign/mgo v0.0.0-20181015135952-eeefdecb41b8/go.mod h1:xkRDCp4j0OGD1HRkm4kmhM+pmpv3AKq5SU7GMg4oO/Q=
@@ -589,7 +585,6 @@ github.com/julienschmidt/httprouter v1.2.0/go.mod h1:SYymIcj16QtmaHHD7aYtjjsJG7V
589585
github.com/julienschmidt/httprouter v1.3.0/go.mod h1:JR6WtHb+2LUe8TCKY3cZOxFyyO8IZAc4RVcycCCAKdM=
590586
github.com/jung-kurt/gofpdf v1.0.3-0.20190309125859-24315acbbda5/go.mod h1:7Id9E/uU8ce6rXgefFLlgrJj/GYY22cpxn+r32jIOes=
591587
github.com/jwilder/encoding v0.0.0-20170811194829-b4e1701a28ef/go.mod h1:Ct9fl0F6iIOGgxJ5npU/IUOhOhqlVrGjyIZc8/MagT0=
592-
github.com/k3s-io/helm-controller v0.11.2 h1:6EoLJJudoTA9m2rdWWpsXWgnmwhsSZNSnCxd4yNrXo0=
593588
github.com/k3s-io/helm-controller v0.11.2/go.mod h1:z0ExsRRIkTO/QC//3/Esn5ItTD6AiQSluwzMaS7RI/4=
594589
github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51/go.mod h1:CzGEWj7cYgsdH8dAjBGEr58BoE7ScuLd+fwFZ44+/x8=
595590
github.com/kisielk/errcheck v1.1.0/go.mod h1:EZBBE59ingxPouuu3KfxchcWSUPOHkagtvWXihfKN4Q=
@@ -613,12 +608,10 @@ github.com/kr/pty v1.1.5/go.mod h1:9r2w37qlBe7rQ6e1fg1S/9xpWHSnaqNdHD3WcMdbPDA=
613608
github.com/kr/text v0.1.0/go.mod h1:4Jbv+DJW3UT/LiOwJeYQe1efqtUx/iVham/4vfdArNI=
614609
github.com/kr/text v0.2.0 h1:5Nx0Ya0ZqY2ygV366QzturHI13Jq95ApcVaJBhpS+AY=
615610
github.com/kr/text v0.2.0/go.mod h1:eLer722TekiGuMkidMxC/pM04lWEeraHUUmBw8l2grE=
616-
github.com/kralicky/gpu-operator v1.8.1-0.20211112183255-72529edf38be h1:j8X7zwJNBX6qcG0P8FZ90mhWpL7MIO7J51XOEglxx7Q=
617611
github.com/kralicky/gpu-operator v1.8.1-0.20211112183255-72529edf38be/go.mod h1:EPT66jj/bM0PXxncqIeD6QEXKM+ddXtQ2tPh7KZsLX8=
618612
github.com/kralicky/highlander v0.0.0-20210804214334-9cfe339efd8a/go.mod h1:ie5ARlfZVi2fyaApaZ/5JFhIs5DaIIFKxwM6rjYa8SE=
619613
github.com/kralicky/kmatch v0.0.0-20210910033132-e5a80a7a45e6 h1:2EyVCvuVcVMG+UIUUurmTIMkBsgC42stXr1gVqKxCLk=
620614
github.com/kralicky/kmatch v0.0.0-20210910033132-e5a80a7a45e6/go.mod h1:GIlN+uSFeISHISm+32UmNce20rNVC5q1Jyz5Wg05cEw=
621-
github.com/kubernetes-sigs/node-feature-discovery-operator v0.2.1-0.20210826163723-568b36491208 h1:QBhf9mF1hatXAj3VOCc4Ycu7x865oR2k4JXNuQwRCRA=
622615
github.com/kubernetes-sigs/node-feature-discovery-operator v0.2.1-0.20210826163723-568b36491208/go.mod h1:5oljBNxBrSTcEQcaTEyv2yEqBudP4pWeF7swUybVnsA=
623616
github.com/lann/builder v0.0.0-20180802200727-47ae307949d0/go.mod h1:dXGbAdH5GtBTC4WfIxhKZfyBF/HBFgRZSWwZ9g/He9o=
624617
github.com/lann/ps v0.0.0-20150810152359-62de8c46ede0/go.mod h1:vmVJ0l/dxyfGW6FmdpVm2joNMFikkuWg0EoCKLGUMNw=
@@ -767,7 +760,6 @@ github.com/opensearch-project/opensearch-go v1.0.0/go.mod h1:FrUl/52DBegRYvK7ISF
767760
github.com/openshift/api v0.0.0-20210216211028-bb81baaf35cd/go.mod h1:aqU5Cq+kqKKPbDMqxo9FojgDeSpNJI7iuskjXjtojDg=
768761
github.com/openshift/build-machinery-go v0.0.0-20200917070002-f171684f77ab/go.mod h1:b1BuldmJlbA/xYtdZvKi+7j5YGB44qJUJDZ9zwiNCfE=
769762
github.com/openshift/client-go v0.0.0-20210112165513-ebc401615f47/go.mod h1:u7NRAjtYVAKokiI9LouzTv4mhds8P4S1TwdVAfbjKSk=
770-
github.com/openshift/custom-resource-status v0.0.0-20210221154447-420d9ecf2a00 h1:w/APGa+Tkf3TUaws5TiPa7ZCkXT0GHY6GK0f/7+MDPc=
771763
github.com/openshift/custom-resource-status v0.0.0-20210221154447-420d9ecf2a00/go.mod h1:GDjWl0tX6FNIj82vIxeudWeSx2Ff6nDZ8uJn0ohUFvo=
772764
github.com/opentracing-contrib/go-observer v0.0.0-20170622124052-a52f23424492/go.mod h1:Ngi6UdF0k5OKD5t5wlmGhe/EDKPoUM3BXZSSfIuJbis=
773765
github.com/opentracing/basictracer-go v1.0.0/go.mod h1:QfBfYuafItcjQuMwinw9GhYKwFXS9KnPs5lxoYwgW74=
@@ -810,7 +802,6 @@ github.com/posener/complete v1.1.1/go.mod h1:em0nMJCgc9GFtwrmVmEMR/ZL6WyhyjMBndr
810802
github.com/pquerna/cachecontrol v0.0.0-20171018203845-0dec1b30a021/go.mod h1:prYjPmNq4d1NPVmpShWobRqXY3q7Vp+80DqgxxUrUIA=
811803
github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring v0.43.0/go.mod h1:udmeCxAYc7D6folUmLnaCXW4RUSX9Y+maxf00eE1meE=
812804
github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring v0.45.0/go.mod h1:3WYi4xqXxGGXWDdQIITnLNmuDzO5n6wYva9spVhR4fg=
813-
github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring v0.50.0 h1:eIYVhtUPLDah0nhcHaWItFM595UAGVFKECaWoW02FUA=
814805
github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring v0.50.0/go.mod h1:3WYi4xqXxGGXWDdQIITnLNmuDzO5n6wYva9spVhR4fg=
815806
github.com/prometheus/client_golang v0.0.0-20180209125602-c332b6f63c06/go.mod h1:7SWBe2y4D6OKWSNQJUaRYU/AaXPKyh/dDVn+NZz0KFw=
816807
github.com/prometheus/client_golang v0.9.1/go.mod h1:7SWBe2y4D6OKWSNQJUaRYU/AaXPKyh/dDVn+NZz0KFw=
@@ -878,7 +869,6 @@ github.com/sean-/seed v0.0.0-20170313163322-e2103e2c3529/go.mod h1:DxrIzT+xaE7yg
878869
github.com/segmentio/kafka-go v0.1.0/go.mod h1:X6itGqS9L4jDletMsxZ7Dz+JFWxM6JHfPOCvTvk+EJo=
879870
github.com/segmentio/kafka-go v0.2.0/go.mod h1:X6itGqS9L4jDletMsxZ7Dz+JFWxM6JHfPOCvTvk+EJo=
880871
github.com/sergi/go-diff v1.0.0/go.mod h1:0CfEIISq7TuYL3j771MWULgwwjU+GofnZX9QAmXWZgo=
881-
github.com/sergi/go-diff v1.1.0 h1:we8PVUC3FE2uYfodKH/nBHMSetSfHDR6scGdBi+erh0=
882872
github.com/sergi/go-diff v1.1.0/go.mod h1:STckp+ISIX8hZLjrqAeVduY0gWCT9IjLuqbuNXdaHfM=
883873
github.com/shopspring/decimal v1.2.0/go.mod h1:DKyhrW/HYNuLGql+MJL6WCR6knT2jwCFRcu2hWCYk4o=
884874
github.com/shurcooL/sanitized_anchor_name v1.0.0/go.mod h1:1NzhyTcUVG4SuEtjjoZeVRXNmyL/1OwPU0+IJeTBvfc=

pkg/resources/opensearch/certs/certs.go

+13-13
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ const (
3535
RESTKeyField = "http.key"
3636
)
3737

38-
type CertsReconciler struct {
38+
type Reconciler struct {
3939
opensearchCluster *v1beta1.OpensearchCluster
4040
client client.Client
4141
ctx context.Context
@@ -44,16 +44,16 @@ type CertsReconciler struct {
4444
recreateCerts bool
4545
}
4646

47-
func NewCertsReconciler(ctx context.Context, client client.Client, recreateCerts bool, cluster *v1beta1.OpensearchCluster) *CertsReconciler {
48-
return &CertsReconciler{
47+
func NewReconciler(ctx context.Context, client client.Client, recreateCerts bool, cluster *v1beta1.OpensearchCluster) *Reconciler {
48+
return &Reconciler{
4949
client: client,
5050
ctx: ctx,
5151
opensearchCluster: cluster,
5252
recreateCerts: recreateCerts,
5353
}
5454
}
5555

56-
func (c *CertsReconciler) setTransportCA(caPEM []byte, caKeyPEM []byte) (err error) {
56+
func (c *Reconciler) setTransportCA(caPEM []byte, caKeyPEM []byte) (err error) {
5757
ca, err := tls.X509KeyPair(caPEM, caKeyPEM)
5858
if err != nil {
5959
return err
@@ -62,7 +62,7 @@ func (c *CertsReconciler) setTransportCA(caPEM []byte, caKeyPEM []byte) (err err
6262
return
6363
}
6464

65-
func (c *CertsReconciler) setRESTCA(caPEM []byte, caKeyPEM []byte) (err error) {
65+
func (c *Reconciler) setRESTCA(caPEM []byte, caKeyPEM []byte) (err error) {
6666
ca, err := tls.X509KeyPair(caPEM, caKeyPEM)
6767
if err != nil {
6868
return err
@@ -71,7 +71,7 @@ func (c *CertsReconciler) setRESTCA(caPEM []byte, caKeyPEM []byte) (err error) {
7171
return
7272
}
7373

74-
func (c *CertsReconciler) retrieveCert(
74+
func (c *Reconciler) retrieveCert(
7575
certField string,
7676
keyField string,
7777
) (
@@ -100,7 +100,7 @@ func (c *CertsReconciler) retrieveCert(
100100
return
101101
}
102102

103-
func (c *CertsReconciler) maybeUpdateTransportCA() (ca []byte, key []byte, err error) {
103+
func (c *Reconciler) maybeUpdateTransportCA() (ca []byte, key []byte, err error) {
104104
ca, key, err = c.retrieveCert(TransportCASecretField, TransportCAKeySecretField)
105105
if k8serrors.IsNotFound(err) || (IsSecretDataMissing(err) && c.recreateCerts) {
106106
ca, key, err = pki.CreateCA("Opensearch Transport CA")
@@ -116,7 +116,7 @@ func (c *CertsReconciler) maybeUpdateTransportCA() (ca []byte, key []byte, err e
116116
return
117117
}
118118

119-
func (c *CertsReconciler) createTransportCert() (cert []byte, key []byte, err error) {
119+
func (c *Reconciler) createTransportCert() (cert []byte, key []byte, err error) {
120120
// We have to add RID Name for the Transport certs
121121
// The oid is 1.2.3.4.5.5. 0x88 is the Tag and Class for RID, 0x5 is the length
122122
// 0x2A is OID standard for the first two numbers - 40 * 1 + 2
@@ -191,7 +191,7 @@ func (c *CertsReconciler) createTransportCert() (cert []byte, key []byte, err er
191191
return
192192
}
193193

194-
func (c *CertsReconciler) createRESTCert() (cert []byte, key []byte, err error) {
194+
func (c *Reconciler) createRESTCert() (cert []byte, key []byte, err error) {
195195
rawValues := []asn1.RawValue{}
196196
dnsNames := []string{
197197
fmt.Sprintf("*.%s", c.opensearchCluster.Namespace),
@@ -259,7 +259,7 @@ func (c *CertsReconciler) createRESTCert() (cert []byte, key []byte, err error)
259259
return
260260
}
261261

262-
func (c *CertsReconciler) maybeUpdateTransportCert() (cert []byte, key []byte, err error) {
262+
func (c *Reconciler) maybeUpdateTransportCert() (cert []byte, key []byte, err error) {
263263
cert, key, err = c.retrieveCert(TransportCertField, TransportKeyField)
264264
if k8serrors.IsNotFound(err) || (IsSecretDataMissing(err) && c.recreateCerts) {
265265
cert, key, err = c.createTransportCert()
@@ -279,7 +279,7 @@ func (c *CertsReconciler) maybeUpdateTransportCert() (cert []byte, key []byte, e
279279
return
280280
}
281281

282-
func (c *CertsReconciler) maybeUpdateRESTCert() (cert []byte, key []byte, err error) {
282+
func (c *Reconciler) maybeUpdateRESTCert() (cert []byte, key []byte, err error) {
283283
cert, key, err = c.retrieveCert(RESTCertField, RESTKeyField)
284284
if k8serrors.IsNotFound(err) || (IsSecretDataMissing(err) && c.recreateCerts) {
285285
cert, key, err = c.createRESTCert()
@@ -299,7 +299,7 @@ func (c *CertsReconciler) maybeUpdateRESTCert() (cert []byte, key []byte, err er
299299
return
300300
}
301301

302-
func (c *CertsReconciler) maybeUpdateRESTCA() (ca []byte, key []byte, err error) {
302+
func (c *Reconciler) maybeUpdateRESTCA() (ca []byte, key []byte, err error) {
303303
ca, key, err = c.retrieveCert(RESTCASecretField, RESTCAKeySecretField)
304304
if k8serrors.IsNotFound(err) || (IsSecretDataMissing(err) && c.recreateCerts) {
305305
ca, key, err = pki.CreateCA("Opensearch REST CA")
@@ -315,7 +315,7 @@ func (c *CertsReconciler) maybeUpdateRESTCA() (ca []byte, key []byte, err error)
315315
return
316316
}
317317

318-
func (c *CertsReconciler) CertSecrets() (resourceList []resources.Resource, err error) {
318+
func (c *Reconciler) CertSecrets() (resourceList []resources.Resource, err error) {
319319
secretPKI := &corev1.Secret{
320320
ObjectMeta: metav1.ObjectMeta{
321321
Name: fmt.Sprintf("%s-os-pki", c.opensearchCluster.Name),

pkg/resources/opensearch/certs/errors.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,5 @@ var (
88
)
99

1010
func IsSecretDataMissing(err error) bool {
11-
return err == ErrSecretDataMissing
11+
return errors.Is(err, ErrSecretDataMissing)
1212
}

0 commit comments

Comments
 (0)