Skip to content

Add resource requests/limits to rancher webhook helm chart #963

Open
@jjsair0412

Description

@jjsair0412

Problem

The rancher-webhook helm chart currently doesn't include resource requests/limits, which can lead to:

  • Resource contention in constrained environments
  • Difficulty in capacity planning
  • Potential scheduling issues

Proposed Solution

Add configurable resource requests/limits to values.yaml and deployment.yaml:

1. Update values.yaml

resources: {}
#  limits:
#    cpu: 100m
#    memory: 128Mi
#  requests:
#    cpu: 100m
#    memory: 128Mi

2. Update templates/deployment.yaml : Add resources section to the container.

        {{- if .Values.resources }}
        resources:
{{ toYaml .Values.resources | indent 10 }}
        {{- end }}

Questions for Maintainers

  1. What would be appropriate default values for typical webhook workloads?
  2. Should this be opt-in (empty by default) or opt-out (with reasonable defaults)?
  3. Any specific Rancher guidelines for webhook resource sizing?

I think this change is better resource management in constrained environments.

I'd be happy to submit a PR once we agree on the approach.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions