Open
Description
Problem
The rancher-webhook helm chart currently doesn't include resource requests/limits, which can lead to:
- Resource contention in constrained environments
- Difficulty in capacity planning
- Potential scheduling issues
Proposed Solution
Add configurable resource requests/limits to values.yaml and deployment.yaml:
1. Update values.yaml
resources: {}
# limits:
# cpu: 100m
# memory: 128Mi
# requests:
# cpu: 100m
# memory: 128Mi
2. Update templates/deployment.yaml
: Add resources section to the container.
{{- if .Values.resources }}
resources:
{{ toYaml .Values.resources | indent 10 }}
{{- end }}
Questions for Maintainers
- What would be appropriate default values for typical webhook workloads?
- Should this be opt-in (empty by default) or opt-out (with reasonable defaults)?
- Any specific Rancher guidelines for webhook resource sizing?
I think this change is better resource management in constrained environments.
I'd be happy to submit a PR once we agree on the approach.
Metadata
Metadata
Assignees
Labels
No labels