Skip to content

Commit ad90b78

Browse files
randleeclaude
andcommitted
docs: Update non-impactful detection plan with Phase 1-2 completion
- Phase 1: Core Infrastructure ✅ (commit 6476acd) - Phase 2: SemanticComparer Integration ✅ (commit 690fd30) - 849 tests pass (100%) Co-Authored-By: Claude Opus 4.5 <[email protected]>
1 parent d025e91 commit ad90b78

File tree

1 file changed

+24
-20
lines changed

1 file changed

+24
-20
lines changed

plans/2026-01-18-non-impactful-change-detection.md

Lines changed: 24 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -557,26 +557,30 @@ The v2 schema adds:
557557

558558
## 7. Implementation Checklist
559559

560-
### Phase 1: Core Infrastructure (Day 1-2)
561-
562-
- [ ] Create `ChangeImpact.cs` enum
563-
- [ ] Create `Visibility.cs` enum
564-
- [ ] Add properties to `Change.cs` record
565-
- [ ] Create `VisibilityExtractor.cs` with Roslyn visitor
566-
- [ ] Create `ImpactClassifier.cs` with classification logic
567-
- [ ] Add unit tests for both new classes
568-
- [ ] **QA Gate:** Run `dotnet test` - must be 100% pass
569-
- [ ] **QA Gate:** Stage, commit, push, create PR to develop
570-
571-
### Phase 2: SemanticComparer Integration (Day 3)
572-
573-
- [ ] Integrate `VisibilityExtractor` into symbol matching
574-
- [ ] Integrate `ImpactClassifier` into change creation
575-
- [ ] Update `DiffOptions` with new properties
576-
- [ ] Update `DiffStats` with impact breakdown
577-
- [ ] Add integration tests
578-
- [ ] **QA Gate:** Run `dotnet test` - must be 100% pass
579-
- [ ] **QA Gate:** Stage, commit, push to PR
560+
### Phase 1: Core Infrastructure (Day 1-2) ✅ COMPLETED 2026-01-18
561+
562+
- [x] Create `ChangeImpact.cs` enum
563+
- [x] Create `Visibility.cs` enum
564+
- [x] Create `SymbolKind.cs` enum (added - needed by ImpactClassifier)
565+
- [x] Add properties to `Change.cs` record (Impact, Visibility, Caveats)
566+
- [x] Create `VisibilityExtractor.cs` with Roslyn visitor
567+
- [x] Create `ImpactClassifier.cs` with classification logic
568+
- [x] Add unit tests for both new classes (59 tests: 23 + 36)
569+
- [x] **QA Gate:** Run `dotnet test` - 844 tests pass (100%)
570+
- [x] **QA Gate:** Stage, commit, push, create PR to develop
571+
- **PR:** https://github.com/randlee/roslyn-diff/pull/34
572+
- **Commit:** 6476acd
573+
574+
### Phase 2: SemanticComparer Integration (Day 3) ✅ COMPLETED 2026-01-18
575+
576+
- [x] Integrate `VisibilityExtractor` into symbol matching
577+
- [x] Integrate `ImpactClassifier` into change creation
578+
- [x] Update `DiffOptions` with new properties (IncludeNonImpactful, MinimumImpactLevel)
579+
- [x] Update `DiffStats` with impact breakdown (BreakingPublicApiCount, etc.)
580+
- [x] Add integration tests (5 tests for impact classification scenarios)
581+
- [x] **QA Gate:** Run `dotnet test` - 849 tests pass (100%)
582+
- [x] **QA Gate:** Stage, commit, push to PR
583+
- **Commit:** 690fd30
580584

581585
### Phase 3: Output Formatters (Day 4)
582586

0 commit comments

Comments
 (0)