Skip to content

Commit 0d2b29d

Browse files
authored
Disable intended disabled ORC tests (#17790)
The following ORC_TEST tests were intended to be disabed: ``` OrcWriterTest.DISABLE_Over65kColumns OrcReaderTest.DISABLE_Over65kStripes OrcReaderTest.DISABLE_Over65kRowGroups ``` Unfortunately they are missing the end `D` and so were not actually disabled. This caused the memcheck nightly build to fail. Changing `DISABLE_` to `DISABLED_` properly disables the tests. Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Bradley Dice (https://github.com/bdice) - Nghia Truong (https://github.com/ttnghia) - Shruti Shivakumar (https://github.com/shrshi) URL: #17790
1 parent b65ad08 commit 0d2b29d

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

cpp/tests/io/orc_test.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -2198,7 +2198,7 @@ TEST_F(OrcChunkedWriterTest, NoDataInSinkWhenNoWrite)
21982198

21992199
// Tests whether Y dimension of grid sizes depends on the number of row groups
22002200
// Disabled because of the high execution time (especially compared to the likelihood of regression)
2201-
TEST_F(OrcReaderTest, DISABLE_Over65kRowGroups)
2201+
TEST_F(OrcReaderTest, DISABLED_Over65kRowGroups)
22022202
{
22032203
auto constexpr row_group_size = 512;
22042204
constexpr auto num_rows = (1 << 16) * row_group_size + 1;
@@ -2222,7 +2222,7 @@ TEST_F(OrcReaderTest, DISABLE_Over65kRowGroups)
22222222

22232223
// Tests whether Y dimension of grid sizes depends on the number of stripes
22242224
// Disabled because of the high execution time (especially compared to the likelihood of regression)
2225-
TEST_F(OrcReaderTest, DISABLE_Over65kStripes)
2225+
TEST_F(OrcReaderTest, DISABLED_Over65kStripes)
22262226
{
22272227
auto constexpr stripe_size = 512;
22282228
constexpr auto num_rows = (1 << 16) * stripe_size + 1;
@@ -2247,7 +2247,7 @@ TEST_F(OrcReaderTest, DISABLE_Over65kStripes)
22472247

22482248
// Tests whether Y dimension of grid sizes depends on the number of columns
22492249
// Disabled because of the high execution time (especially compared to the likelihood of regression)
2250-
TEST_F(OrcWriterTest, DISABLE_Over65kColumns)
2250+
TEST_F(OrcWriterTest, DISABLED_Over65kColumns)
22512251
{
22522252
auto vals_col = random_values<int32_t>(8);
22532253
dec64_col col{vals_col.begin(), vals_col.end(), numeric::scale_type{2}};

0 commit comments

Comments
 (0)