Skip to content

Commit

Permalink
Disable intended disabled ORC tests (#17790)
Browse files Browse the repository at this point in the history
The following ORC_TEST tests were intended to be disabed:
```
OrcWriterTest.DISABLE_Over65kColumns
OrcReaderTest.DISABLE_Over65kStripes
OrcReaderTest.DISABLE_Over65kRowGroups
```
Unfortunately they are missing the end `D` and so were not actually disabled. This caused the memcheck nightly build to fail.
Changing `DISABLE_` to `DISABLED_` properly disables the tests.

Authors:
  - David Wendt (https://github.com/davidwendt)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Nghia Truong (https://github.com/ttnghia)
  - Shruti Shivakumar (https://github.com/shrshi)

URL: #17790
  • Loading branch information
davidwendt authored Jan 24, 2025
1 parent b65ad08 commit 0d2b29d
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions cpp/tests/io/orc_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2198,7 +2198,7 @@ TEST_F(OrcChunkedWriterTest, NoDataInSinkWhenNoWrite)

// Tests whether Y dimension of grid sizes depends on the number of row groups
// Disabled because of the high execution time (especially compared to the likelihood of regression)
TEST_F(OrcReaderTest, DISABLE_Over65kRowGroups)
TEST_F(OrcReaderTest, DISABLED_Over65kRowGroups)
{
auto constexpr row_group_size = 512;
constexpr auto num_rows = (1 << 16) * row_group_size + 1;
Expand All @@ -2222,7 +2222,7 @@ TEST_F(OrcReaderTest, DISABLE_Over65kRowGroups)

// Tests whether Y dimension of grid sizes depends on the number of stripes
// Disabled because of the high execution time (especially compared to the likelihood of regression)
TEST_F(OrcReaderTest, DISABLE_Over65kStripes)
TEST_F(OrcReaderTest, DISABLED_Over65kStripes)
{
auto constexpr stripe_size = 512;
constexpr auto num_rows = (1 << 16) * stripe_size + 1;
Expand All @@ -2247,7 +2247,7 @@ TEST_F(OrcReaderTest, DISABLE_Over65kStripes)

// Tests whether Y dimension of grid sizes depends on the number of columns
// Disabled because of the high execution time (especially compared to the likelihood of regression)
TEST_F(OrcWriterTest, DISABLE_Over65kColumns)
TEST_F(OrcWriterTest, DISABLED_Over65kColumns)
{
auto vals_col = random_values<int32_t>(8);
dec64_col col{vals_col.begin(), vals_col.end(), numeric::scale_type{2}};
Expand Down

0 comments on commit 0d2b29d

Please sign in to comment.