Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]filter test perfroms wrong when GDF_LESS_THAN #1336

Closed
StevenXJH opened this issue Apr 2, 2019 · 3 comments
Closed

[BUG]filter test perfroms wrong when GDF_LESS_THAN #1336

StevenXJH opened this issue Apr 2, 2019 · 3 comments
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. Needs Triage Need team to review and classify

Comments

@StevenXJH
Copy link

filter_ops.cu
The comparison operations have bugs in the LESS_THAN condition, which makes it perform as same as the GREATER_THAN condition.

Code to reproduce bug
rapidsai/cudf/cpp/src/filter/filter_ops.cu: Line 62 &Line 72.
Both ">" should be "<".

Expected behavior
No mix between greater than and less than

@StevenXJH StevenXJH added Needs Triage Need team to review and classify bug Something isn't working labels Apr 2, 2019
@harrism
Copy link
Member

harrism commented Apr 4, 2019

@StevenJoker can you please use a GitHub link to the exact lines? Or provide a commit hash. Without a link or hash, we might not get the right version of the file. This code is undergoing change.

@harrism harrism added the libcudf Affects libcudf (C++/CUDA) code. label Apr 4, 2019
@StevenXJH
Copy link
Author

return x > y;

and
return x >= y;

@harrism
Copy link
Member

harrism commented Apr 4, 2019

Thanks @StevenJoker . filter_ops.cu is deleted by PR #1076 which is about to be merged. The functionality is replaced by binary operations. #892 has already been merged which implements that change. CC @devavret

@harrism harrism closed this as completed Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. Needs Triage Need team to review and classify
Projects
None yet
Development

No branches or pull requests

2 participants