You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Also, the change will proliferate to several other primitives that use the above 2. For example, in raft/linalg/matrix_vector_op.cuh, there is the opportunity to convert both rowMajor and bcastAlongRows to template parameters. Once the original API changes, the results will cascade down to other caller sites as well.
Uh oh!
There was an error while loading. Please reload this page.
The invocations can be converted to compile time features at 2 places:
raft/cpp/include/raft/matrix/detail/linewise_op.cuh
Lines 767 to 773 in cc165d9
raft/cpp/include/raft/matrix/detail/linewise_op.cuh
Lines 799 to 815 in cc165d9
This struct has callers in:
raft/matrix/linewise_op.cuh
raft/cpp/include/raft/matrix/linewise_op.cuh
Line 85 in cc165d9
raft/cpp/include/raft/matrix/linewise_op.cuh
Line 120 in cc165d9
raft/matrix/matrix.cuh
raft/cpp/include/raft/matrix/matrix.cuh
Line 304 in cc165d9
Also, the change will proliferate to several other primitives that use the above 2. For example, in
raft/linalg/matrix_vector_op.cuh
, there is the opportunity to convert bothrowMajor
andbcastAlongRows
to template parameters. Once the original API changes, the results will cascade down to other caller sites as well.raft/cpp/include/raft/linalg/detail/matrix_vector_op.cuh
Lines 39 to 55 in cc165d9
The text was updated successfully, but these errors were encountered: