Rollback @prettier/plugin-xml (see prettier/plugin-xml#784)

craftercms/craftercms#7748

Author: rart

ui/app/package.json

@@ -69,7 +69,7 @@
 		"@mui/x-data-grid": "^7.27.2",
 		"@mui/x-date-pickers": "^7.27.1",
 		"@mui/x-tree-view": "^7.26.0",
-		"@prettier/plugin-xml": "3.4.1",
+		"@prettier/plugin-xml": "3.3.0",
 		"@reduxjs/toolkit": "^2.6.0",
 		"@stomp/stompjs": "^7.0.0",
 		"@tinymce/tinymce-react": "^5.1.1",

ui/app/src/utils/xml.ts

@@ -28,11 +28,15 @@ export function serialize(doc: Node): string {
 	return new XMLSerializer().serializeToString(doc);
 }
 
-interface BeautifyOptions {
+export interface BeautifyOptions {
 	tabWidth: number;
 	printWidth: number;
-	xmlWhitespaceSensitivity: 'ignore' | 'strict';
 	xmlSelfClosingSpace: boolean;
+	xmlWhitespaceSensitivity: 'strict' | 'preserve' | 'ignore';
+	xmlSortAttributesByKey: boolean;
+	xmlQuoteAttributes: 'preserve' | 'single' | 'double';
+	singleAttributePerLine: boolean;
+	bracketSameLine: boolean;
 }
 
 export function beautify(xml: string): Promise<string>;
@@ -41,10 +45,13 @@ export function beautify(xml: string, options?: Partial<BeautifyOptions>): Promi
 	return format(xml, {
 		tabWidth: 2,
 		printWidth: +Infinity,
+		// @prettier/plugin-xml v3.3.1 breaks xmlWhitespaceSensitivity behaviour: encoded entities started
+		// to get spaces in between the encoded `<`, `>`, and tag name, breaking the decoding.
+		// Setting xmlWhitespaceSensitivity to 'preserve' would prevent the issue, but it has consequences
+		// on the desired format result. See https://github.com/prettier/plugin-xml/issues/784.
 		xmlWhitespaceSensitivity: 'ignore',
 		xmlSelfClosingSpace: true,
 		...options,
-		// @ts-ignore
 		parser: 'xml',
 		plugins: [prettierXmlPlugin]
 	});

yarn.lock

@@ -1593,7 +1593,7 @@ __metadata:
     "@mui/x-data-grid": "npm:^7.27.2"
     "@mui/x-date-pickers": "npm:^7.27.1"
     "@mui/x-tree-view": "npm:^7.26.0"
-    "@prettier/plugin-xml": "npm:3.4.1"
+    "@prettier/plugin-xml": "npm:3.3.0"
     "@reduxjs/toolkit": "npm:^2.6.0"
     "@rollup/plugin-swc": "npm:^0.4.0"
     "@stomp/stompjs": "npm:^7.0.0"
@@ -3297,6 +3297,17 @@ __metadata:
   languageName: node
   linkType: hard
 
+"@prettier/plugin-xml@npm:3.3.0":
+  version: 3.3.0
+  resolution: "@prettier/plugin-xml@npm:3.3.0"
+  dependencies:
+    "@xml-tools/parser": "npm:^1.0.11"
+  peerDependencies:
+    prettier: ^3.0.0
+  checksum: 10/0f33b044af7d7a79fdf73a4754aed56f73efbf200be24efa40ef5f52b849243ddfe5a27ec3f1ad7ffdc21b6b0015319509a37cd365f6f52466df41c0eeec3b4d
+  languageName: node
+  linkType: hard
+
 "@prettier/plugin-xml@npm:3.4.1":
   version: 3.4.1
   resolution: "@prettier/plugin-xml@npm:3.4.1"