comment

- adding # NEW for assert num_heads % num_kv_groups == 0

Author: casinca

ch05/07_gpt_to_llama/converting-llama2-to-llama3.ipynb

@@ -481,7 +481,7 @@
     "        ):\n",
     "        super().__init__()\n",
     "        assert d_out % num_heads == 0, \"d_out must be divisible by num_heads\"\n",
-    "        assert num_heads % num_kv_groups == 0, \"num_heads must be divisible by num_kv_groups\"\n",
+    "        assert num_heads % num_kv_groups == 0, \"num_heads must be divisible by num_kv_groups\"  # NEW\n",
     "\n",
     "        self.d_out = d_out\n",
     "        self.num_heads = num_heads\n",