Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider reorganizing things related to arena #119

Open
ishitatsuyuki opened this issue Jan 16, 2019 · 1 comment
Open

Consider reorganizing things related to arena #119

ishitatsuyuki opened this issue Jan 16, 2019 · 1 comment

Comments

@ishitatsuyuki
Copy link
Contributor

The current AST types uses CopyCell from toolshed, which is not really sound. Adding to that, interior mutability is inherently confusing.

I propose that we move back to normal heap allocated objects if the performance difference is small; otherwise, we should consider saving &mut in types.

Also, while toolshed requires Copy bound, it's not always necessary as rustc's DroplessArena shows. We could either use a reimplementation of that or simply typed-arena.

@ishitatsuyuki
Copy link
Contributor Author

I discussed with @maciejhirsz and agreed on moving back to normal heap allocated objects for the meanwhile.

As the replacement for CopyCell, my plan is to implement MutVisitor like the one in rustc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant