Skip to content

Commit 682c46b

Browse files
davidxiadavidxia
authored
chore: comment out unnecessary empty rayStartParams (#3586)
1 parent cfd90d8 commit 682c46b

34 files changed

+10
-63
lines changed

‎apiserver/test/cluster/cluster_external_redis.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,10 +75,6 @@ spec:
7575
minReplicas: 1
7676
maxReplicas: 10
7777
groupName: small-group
78-
# The `rayStartParams` are used to configure the `ray start` command.
79-
# See https://github.com/ray-project/kuberay/blob/master/docs/guidance/rayStartParams.md for the default settings of `rayStartParams` in KubeRay.
80-
# See https://docs.ray.io/en/latest/cluster/cli.html#ray-start for all available options in `rayStartParams`.
81-
rayStartParams: {}
8278
# Pod template
8379
template:
8480
spec:

‎benchmark/memory_benchmark/scripts/ray-cluster.benchmark.yaml.template

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ spec:
3232
minReplicas: 0
3333
maxReplicas: 200
3434
groupName: small-group
35-
rayStartParams: {}
3635
template:
3736
spec:
3837
containers:

‎benchmark/perf-tests/100-raycluster/raycluster.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ spec:
3838
maxReplicas: 10
3939
# logical group name, for this called small-group, also can be functional
4040
groupName: small-group
41-
rayStartParams: {}
4241
template:
4342
spec:
4443
containers:

‎benchmark/perf-tests/100-rayjob/pytorch-mnist-rayjob.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ spec:
1515
rayClusterSpec:
1616
rayVersion: '2.46.0'
1717
headGroupSpec:
18-
rayStartParams: {}
1918
template:
2019
spec:
2120
containers:
@@ -39,7 +38,6 @@ spec:
3938
minReplicas: 1
4039
maxReplicas: 5
4140
groupName: worker-group
42-
rayStartParams: {}
4341
template:
4442
spec:
4543
containers:

‎benchmark/perf-tests/100-rayjob/ray-data-image-resize.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ spec:
1010
rayClusterSpec:
1111
rayVersion: '2.46.0'
1212
headGroupSpec:
13-
rayStartParams: {}
1413
template:
1514
spec:
1615
containers:
@@ -34,7 +33,6 @@ spec:
3433
minReplicas: 1
3534
maxReplicas: 5
3635
groupName: worker-group
37-
rayStartParams: {}
3836
template:
3937
spec:
4038
containers:

‎benchmark/perf-tests/1000-raycluster/raycluster.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ spec:
3737
maxReplicas: 10
3838
# logical group name, for this called small-group, also can be functional
3939
groupName: small-group
40-
rayStartParams: {}
4140
template:
4241
spec:
4342
containers:

‎benchmark/perf-tests/1000-rayjob/pytorch-mnist-rayjob.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ spec:
5151
minReplicas: 1
5252
maxReplicas: 5
5353
groupName: worker-group
54-
rayStartParams: {}
5554
template:
5655
spec:
5756
containers:

‎benchmark/perf-tests/1000-rayjob/ray-data-image-resize.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ spec:
5151
minReplicas: 1
5252
maxReplicas: 5
5353
groupName: worker-group
54-
rayStartParams: {}
5554
template:
5655
spec:
5756
containers:

‎benchmark/perf-tests/10000-raycluster/raycluster.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ spec:
3636
minReplicas: 1
3737
maxReplicas: 10
3838
groupName: small-group
39-
rayStartParams: {}
4039
template:
4140
spec:
4241
containers:

‎benchmark/perf-tests/10000-rayjob/pytorch-mnist-rayjob.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ spec:
5151
minReplicas: 1
5252
maxReplicas: 5
5353
groupName: worker-group
54-
rayStartParams: {}
5554
template:
5655
spec:
5756
containers:

‎benchmark/perf-tests/10000-rayjob/ray-data-image-resize.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ spec:
5151
minReplicas: 1
5252
maxReplicas: 5
5353
groupName: worker-group
54-
rayStartParams: {}
5554
template:
5655
spec:
5756
containers:

‎benchmark/perf-tests/5000-raycluster/raycluster.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ spec:
3636
minReplicas: 1
3737
maxReplicas: 10
3838
groupName: small-group
39-
rayStartParams: {}
4039
template:
4140
spec:
4241
containers:

‎benchmark/perf-tests/5000-rayjob/pytorch-mnist-rayjob.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ spec:
5151
minReplicas: 1
5252
maxReplicas: 5
5353
groupName: worker-group
54-
rayStartParams: {}
5554
template:
5655
spec:
5756
containers:

‎benchmark/perf-tests/5000-rayjob/ray-data-image-resize.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ spec:
5151
minReplicas: 1
5252
maxReplicas: 5
5353
groupName: worker-group
54-
rayStartParams: {}
5554
template:
5655
spec:
5756
containers:

‎helm-chart/ray-cluster/templates/raycluster-cluster.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ spec:
3838
{{ $key }}: {{ $val | quote }}
3939
{{- end }}
4040
{{- else }}
41-
rayStartParams: {}
4241
{{- end }}
4342
template:
4443
metadata:
@@ -165,7 +164,6 @@ spec:
165164
{{ $key }}: {{ $val | quote }}
166165
{{- end }}
167166
{{- else }}
168-
rayStartParams: {}
169167
{{- end }}
170168
template:
171169
metadata:
@@ -293,7 +291,6 @@ spec:
293291
{{ $key }}: {{ $val | quote }}
294292
{{- end }}
295293
{{- else }}
296-
rayStartParams: {}
297294
{{- end }}
298295
template:
299296
metadata:

‎helm-chart/ray-cluster/values.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ head:
5858
# in the headGroupSpec. See https://github.com/ray-project/kuberay/pull/1128 for more details.
5959
serviceAccountName: ""
6060
restartPolicy: ""
61-
rayStartParams: {}
6261
# containerEnv specifies environment variables for the Ray container,
6362
# Follows standard K8s container env schema.
6463
containerEnv: []
@@ -141,7 +140,6 @@ worker:
141140
labels: {}
142141
serviceAccountName: ""
143142
restartPolicy: ""
144-
rayStartParams: {}
145143
initContainers: []
146144
# containerEnv specifies environment variables for the Ray container,
147145
# Follows standard K8s container env schema.
@@ -220,7 +218,6 @@ additionalWorkerGroups:
220218
labels: {}
221219
serviceAccountName: ""
222220
restartPolicy: ""
223-
rayStartParams: {}
224221
# containerEnv specifies environment variables for the Ray container,
225222
# Follows standard K8s container env schema.
226223
containerEnv: []

‎kubectl-plugin/test/e2e/testdata/ray-job.interactive-mode-no-runtime-env.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ spec:
77
rayClusterSpec:
88
rayVersion: '2.46.0'
99
headGroupSpec:
10-
rayStartParams: {}
1110
template:
1211
spec:
1312
containers:
@@ -30,7 +29,6 @@ spec:
3029
minReplicas: 1
3130
maxReplicas: 5
3231
groupName: small-group
33-
rayStartParams: {}
3432
template:
3533
spec:
3634
containers:

‎kubectl-plugin/test/e2e/testdata/ray-job.interactive-mode.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ spec:
1616
rayClusterSpec:
1717
rayVersion: '2.46.0' # should match the Ray version in the image of the containers
1818
headGroupSpec:
19-
rayStartParams: {}
2019
template:
2120
spec:
2221
containers:
@@ -39,7 +38,6 @@ spec:
3938
minReplicas: 1
4039
maxReplicas: 5
4140
groupName: small-group
42-
rayStartParams: {}
4341
template:
4442
spec:
4543
containers:

‎ray-operator/config/samples/ray-cluster.embed-grafana.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@ spec:
88
rayStartParams: {}
99
# pod template
1010
template:
11-
metadata:
12-
labels: {}
1311
spec:
1412
containers:
1513
- name: ray-head

‎ray-operator/config/samples/ray-cluster.sample.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ spec:
99
rayVersion: '2.46.0' # should match the Ray version in the image of the containers
1010
# Ray head pod template
1111
headGroupSpec:
12+
# rayStartParams is optional with RayCluster CRD from KubeRay 1.4.0 or later but required in earlier versions.
1213
rayStartParams: {}
13-
#pod template
1414
template:
1515
spec:
1616
containers:
@@ -37,8 +37,8 @@ spec:
3737
maxReplicas: 5
3838
# logical group name, for this called small-group, also can be functional
3939
groupName: workergroup
40+
# rayStartParams is optional with RayCluster CRD from KubeRay 1.4.0 or later but required in earlier versions.
4041
rayStartParams: {}
41-
#pod template
4242
template:
4343
spec:
4444
containers:

‎ray-operator/config/samples/ray-cluster.tpu-v4-multihost.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,12 +47,12 @@ spec:
4747
- containerPort: 8081
4848
name: mxla
4949
workerGroupSpecs:
50-
- rayStartParams: {}
51-
replicas: 1
50+
- replicas: 1
5251
minReplicas: 1
5352
maxReplicas: 1
5453
numOfHosts: 2
5554
groupName: tpu-group
55+
rayStartParams: {}
5656
template:
5757
spec:
5858
containers:

‎ray-operator/config/samples/ray-cluster.tpu-v4-singlehost.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,12 @@ spec:
4343
- containerPort: 8000
4444
name: serve
4545
workerGroupSpecs:
46-
- rayStartParams: {}
47-
replicas: 1
46+
- replicas: 1
4847
minReplicas: 1
4948
maxReplicas: 1
5049
numOfHosts: 1
5150
groupName: tpu-group
51+
rayStartParams: {}
5252
template:
5353
spec:
5454
containers:

‎ray-operator/config/samples/ray-cluster.volcano-scheduler-queue.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,10 @@ spec:
3333
memory: "2Gi"
3434
workerGroupSpecs:
3535
- groupName: worker
36-
rayStartParams: {}
3736
replicas: 2
3837
minReplicas: 2
3938
maxReplicas: 2
39+
rayStartParams: {}
4040
template:
4141
spec:
4242
containers:

‎ray-operator/config/samples/ray-cluster.yunikorn-scheduler.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@ spec:
2424
memory: "2Gi"
2525
workerGroupSpecs:
2626
- groupName: worker
27-
rayStartParams: {}
2827
replicas: 2
2928
minReplicas: 2
3029
maxReplicas: 2
30+
rayStartParams: {}
3131
template:
3232
spec:
3333
containers:

‎ray-operator/config/samples/ray-data-image-resize/ray-data-image-resize-gcsfusecsi-job.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,8 @@ spec:
6666
- groupName: worker-group
6767
maxReplicas: 3
6868
minReplicas: 1
69-
rayStartParams: {}
7069
replicas: 3
70+
rayStartParams: {}
7171
template:
7272
metadata:
7373
annotations:

‎ray-operator/config/samples/ray-job.interactive-mode.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ spec:
3636
rayVersion: 2.46.0
3737
workerGroupSpecs:
3838
- groupName: default-group
39-
rayStartParams: {}
4039
replicas: 1
40+
rayStartParams: {}
4141
template:
4242
spec:
4343
containers:

‎ray-operator/config/samples/ray-service.mobilenet.yaml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,6 @@ spec:
2020
######################headGroupSpecs#################################
2121
# Ray head pod template.
2222
headGroupSpec:
23-
# The `rayStartParams` are used to configure the `ray start` command.
24-
# See https://github.com/ray-project/kuberay/blob/master/docs/guidance/rayStartParams.md for the default settings of `rayStartParams` in KubeRay.
25-
# See https://docs.ray.io/en/latest/cluster/cli.html#ray-start for all available options in `rayStartParams`.
2623
rayStartParams: {}
2724
#pod template
2825
template:
@@ -44,9 +41,6 @@ spec:
4441
maxReplicas: 5
4542
# logical group name, for this called small-group, also can be functional
4643
groupName: worker
47-
# The `rayStartParams` are used to configure the `ray start` command.
48-
# See https://github.com/ray-project/kuberay/blob/master/docs/guidance/rayStartParams.md for the default settings of `rayStartParams` in KubeRay.
49-
# See https://docs.ray.io/en/latest/cluster/cli.html#ray-start for all available options in `rayStartParams`.
5044
rayStartParams: {}
5145
#pod template
5246
template:

‎ray-operator/config/samples/ray-service.stable-diffusion.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,6 @@ spec:
1515
######################headGroupSpecs#################################
1616
# Ray head pod template.
1717
headGroupSpec:
18-
# The `rayStartParams` are used to configure the `ray start` command.
19-
# See https://github.com/ray-project/kuberay/blob/master/docs/guidance/rayStartParams.md for the default settings of `rayStartParams` in KubeRay.
20-
# See https://docs.ray.io/en/latest/cluster/cli.html#ray-start for all available options in `rayStartParams`.
2118
rayStartParams: {}
2219
# Pod template
2320
template:

‎ray-operator/config/samples/ray-service.text-ml.yaml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,6 @@ spec:
3434
######################headGroupSpecs#################################
3535
# Ray head pod template.
3636
headGroupSpec:
37-
# The `rayStartParams` are used to configure the `ray start` command.
38-
# See https://github.com/ray-project/kuberay/blob/master/docs/guidance/rayStartParams.md for the default settings of `rayStartParams` in KubeRay.
39-
# See https://docs.ray.io/en/latest/cluster/cli.html#ray-start for all available options in `rayStartParams`.
4037
rayStartParams: {}
4138
#pod template
4239
template:
@@ -58,9 +55,6 @@ spec:
5855
maxReplicas: 5
5956
# logical group name, for this called small-group, also can be functional
6057
groupName: small-group
61-
# The `rayStartParams` are used to configure the `ray start` command.
62-
# See https://github.com/ray-project/kuberay/blob/master/docs/guidance/rayStartParams.md for the default settings of `rayStartParams` in KubeRay.
63-
# See https://docs.ray.io/en/latest/cluster/cli.html#ray-start for all available options in `rayStartParams`.
6458
rayStartParams: {}
6559
#pod template
6660
template:

‎ray-operator/config/samples/ray-service.text-summarizer.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,6 @@ spec:
1414
######################headGroupSpecs#################################
1515
# Ray head pod template.
1616
headGroupSpec:
17-
# The `rayStartParams` are used to configure the `ray start` command.
18-
# See https://github.com/ray-project/kuberay/blob/master/docs/guidance/rayStartParams.md for the default settings of `rayStartParams` in KubeRay.
19-
# See https://docs.ray.io/en/latest/cluster/cli.html#ray-start for all available options in `rayStartParams`.
2017
rayStartParams: {}
2118
# Pod template
2219
template:

‎ray-operator/test/e2erayservice/testdata/locust-cluster.burst.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ metadata:
55
spec:
66
rayVersion: '2.46.0'
77
headGroupSpec:
8-
rayStartParams: {}
98
template:
109
spec:
1110
containers:

‎ray-operator/test/e2erayservice/testdata/locust-cluster.const-rate.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ metadata:
55
spec:
66
rayVersion: '2.46.0'
77
headGroupSpec:
8-
rayStartParams: {}
98
template:
109
spec:
1110
containers:

‎ray-operator/test/e2erayservice/testdata/rayservice.autoscaling.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@ spec:
5959
minReplicas: 0
6060
maxReplicas: 5
6161
groupName: small-group
62-
rayStartParams: {}
6362
template:
6463
spec:
6564
containers:

0 commit comments

Comments
 (0)