Skip to content

Improve Grafana Dashboard #3734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 7, 2025
Merged

Improve Grafana Dashboard #3734

merged 6 commits into from
Jun 7, 2025
+57 −258

Conversation

troychiu
Copy link
Contributor

@troychiu troychiu commented Jun 3, 2025 •
edited
Loading

Why are these changes needed?

This PR improves the grafana dashboard for kuberay operator, including

  1. use irate for reconciliation rate to ensure correct result.
  2. remove some redundant information
  3. refine some titles and description.

Related issue number

None

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@troychiu
improve
9851c94 
Signed-off-by: Troy Chiu <[email protected]>
@troychiu troychiu changed the title improve Improve Grafana Dashboard Jun 3, 2025
@win5923 win5923 mentioned this pull request Jun 4, 2025
Open
8 tasks
troychiu added 2 commits June 5, 2025 01:36
@troychiu
improve
82823ff 
Signed-off-by: Troy Chiu <[email protected]>
@troychiu
nit
13ab552 
Signed-off-by: Troy Chiu <[email protected]>
@troychiu troychiu marked this pull request as ready for review June 5, 2025 08:40
@troychiu
Copy link
Contributor Author

troychiu commented Jun 5, 2025

cc @win5923 @owenowenisme

troychiu added 2 commits June 6, 2025 00:14
@troychiu
code review
e5944a3 
Signed-off-by: Troy Chiu <[email protected]>
@troychiu
nit
94b2b2f 
Signed-off-by: Troy Chiu <[email protected]>
owenowenisme
owenowenisme approved these changes Jun 6, 2025
View reviewed changes
Copy link
Contributor

@owenowenisme owenowenisme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owenowenisme
Copy link
Contributor

cc @kevin85421

@troychiu
add description
ccd8ca6 
Signed-off-by: Troy Chiu <[email protected]>
@kevin85421 kevin85421 merged commit bdbf379 into ray-project:master Jun 7, 2025
25 checks passed
@MortalHappiness MortalHappiness mentioned this pull request Jun 10, 2025
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin85421 kevin85421 kevin85421 approved these changes

@win5923 win5923 win5923 approved these changes

@owenowenisme owenowenisme owenowenisme approved these changes

Assignees
No one assigned
Labels
1.4.0 release-blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@troychiu @owenowenisme @kevin85421 @win5923