Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on resume export when basics.summary does not exist #10

Closed
christopherseaman opened this issue Mar 9, 2021 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@christopherseaman
Copy link

For making resumes without an "About" section.

To reproduce, in a clean dir:

  1. run resume init (fill in name/email)
  2. edit resume.json to delete the summary line in basics
  3. run resume export output.html -t even
  4. error occurs (output attached)
    error.txt

Tested and the same resume.json does export using the elegant theme and when a blank summary line ("summary": "",) is included although that produces an undesired blank summary line on the output as well (example).

Oddly enough, this seems to work as desired on registry.jsonresume.org (see attached pics with and without a blank summary line in the basics obj).

with_summary

without_summary

@rbardini rbardini added the bug Something isn't working label Mar 9, 2021
@rbardini
Copy link
Owner

rbardini commented Mar 9, 2021

Thanks for the report, @christopherseaman! This has been fixed in v0.10.1.

Note that you may have to wait until the dependency version is updated in resume-cli, unless you use one of the other methods described in the README 😉

@christopherseaman
Copy link
Author

Thanks for the (amazingly) quick response. Confirmed working.

resume.json on  master [✘?⇣] via ⬢ v15.11.0 on ☁️ [email protected] 
❯ resume export asdf.html -r resume_with_summary.json

Done! Find your new .html resume at:
 /Users/christopher/Documents/Development/resume.json/asdf.html

resume.json on  master [✘?⇣] via ⬢ v15.11.0 on ☁️ [email protected] 
❯ resume export asdf.html -r resume_without_summary.json

Done! Find your new .html resume at:
 /Users/christopher/Documents/Development/resume.json/asdf.html

resume.json on  master [✘?⇣] via ⬢ v15.11.0 on ☁️ [email protected] 
❯ npm list
resume.json@ /Users/christopher/Documents/Development/resume.json
└── [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants