Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(projects): display project type and keywords #18

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

roschaefer
Copy link
Contributor

@roschaefer roschaefer commented Aug 30, 2023

Motivation

I'm using keywords extensively in my CV. It turns out that resume-schema specifies these for projects too. I would expect the reference implementation here to do something with it.

How to test

  1. npm run test
  2. Test pass

or

  1. npm run build:demo
  2. http-server public
  3. Visit localhost:8080
  4. See keywords GoogleMaps, Chrome Extension, Javascript and type application

image

Motivation
----------
I'm using `keywords` extensively in my CV. It turns out that [resume-schema](https://github.com/jsonresume/resume-schema/blob/master/schema.json) specifies these for `projects` too. I would expect the reference implementation here to do something with it.

How to test
-----------
1. `npm run test`
2. Test pass

*or*

1. `npm run build:demo`
2. `http-server public`
3. Visit [localhost:8080](http://localhost:8080/)
4. See keywords `GoogleMaps`, `Chrome Extension`, `Javascript` and type `application`
@rbardini rbardini linked an issue Sep 1, 2023 that may be closed by this pull request
@rbardini rbardini added the enhancement New feature or request label Sep 1, 2023
@rbardini
Copy link
Owner

rbardini commented Sep 1, 2023

This is great, thanks @roschaefer! I reformatted the code to make the PR smaller—most of the code is not following Prettier yet.

I also moved the tag list below project highlights, and declared a default value for keywords to avoid things breaking if keywords are not defined in the resume.

@rbardini rbardini changed the title feat: display projects.keywords and .type feat(projects): display project type and keywords Sep 1, 2023
@rbardini rbardini merged commit 501ca1a into rbardini:main Sep 1, 2023
@rbardini
Copy link
Owner

rbardini commented Sep 1, 2023

Released in v0.20.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing type in projects
2 participants