Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MRL recommended IP node ban list #42

Closed
rottenwheel opened this issue Dec 14, 2024 · 2 comments · Fixed by #43
Closed

Add MRL recommended IP node ban list #42

rottenwheel opened this issue Dec 14, 2024 · 2 comments · Fixed by #43
Assignees
Labels
enhancement New feature or request

Comments

@rottenwheel
Copy link

@rblaine95 rblaine95 self-assigned this Dec 14, 2024
@rblaine95 rblaine95 added the enhancement New feature or request label Dec 14, 2024
@rblaine95
Copy link
Owner

rblaine95 commented Dec 14, 2024

Hey @rottenwheel, thank you for opening the issue.

I'm not sure about packaging a ban list directly in the docker image.

If you want to use the ban list, you can simply:
wget https://raw.githubusercontent.com/Boog900/monero-ban-list/refs/heads/main/ban_list.txt -O ./monero-data/ban_list.txt
and then in Docker Compose (for example):

  monerod:
    container_name: monerod
    image: ghcr.io/rblaine95/monero
    restart: unless-stopped
    network_mode: host
    volumes:
      - ./monero-data:/opt/bitmonero
    command:
      - --ban-list=/opt/bitmonero/ban_list.txt

Or:

docker run \
  -dit \
  --restart=always \
  --net=host \
  --name=monerod \
  -v /path/to/bitmonero:/opt/bitmonero \
  ghcr.io/rblaine95/monero \
    --ban-list=/opt/bitmonero/ban_list.txt

I'm happy to discuss packaging the ban list directly in the docker image, however, ultimately, I think it's up to whoever uses this docker image whether they want to use the list or not.

Maybe, instead of packaging the ban list in the image itself I can add examples in the Docker Compose and Readme on acquiring the ban list and linking to the issue?

@rblaine95
Copy link
Owner

Hey @rottenwheel, I've opened a PR for this (#43) please take a look and let me know what you think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants