Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iframe on front page of demo site needs to be resized so that there is no scrollbar #86

Open
2 tasks
pacharanero opened this issue Mar 12, 2023 · 1 comment

Comments

@pacharanero
Copy link
Member

See https://growth.rcpch.ac.uk/

The demo site is embedded as an iframe, from a static React site which is CI'd in GitHub Pages and is live at https://rcpch.github.io/digital-growth-charts-react-client/

However the content of the demo client must have changed slightly and now it is displaying with a scroll bar, which is undesirable from an appearance point of view

  • resize the iframe constraints to fit without needing a scroll bar
  • (optional) see if there is a way to make it auto-adapt to future changes in demo client size
@eatyourpeas eatyourpeas transferred this issue from another repository Mar 12, 2023
@Raxxius
Copy link

Raxxius commented Nov 30, 2023

This issue will be resolved by completing issue:

Embed growth chart client into mkdocs, remove iframe #91

from rcpch/digital-growth-charts-react-client#91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants