[Actions][Linux] Add more extensions to be built, fix all compile warnings and errors (#2039)

* Fix compile warnings and errors in the extensions to add them to Actions

* Add more extensions to be built and sort all of them

* Update Thunder job to use development branch

* Fix compile warnings in the CheckPointServer.c

* One more strncpy warning fixed

* Update Thunder workflow to use master branch

Author: VeithMetro

.github/workflows/Linux build template.yml

@@ -153,17 +153,20 @@ jobs:
         -DPROXYSTUB_PATH="${PWD}/${{matrix.build_type}}/install/usr/lib/wpeframework/proxystubs" \
         -DSYSTEM_PATH="${PWD}/${{matrix.build_type}}/install/usr/lib/wpeframework/plugins" \
         -DVOLATILE_PATH="tmp" \
-        -DBLUETOOTH_SUPPORT=ON \
         -DBLUETOOTH=ON \
-        -DDOWNLOAD_BLUEZ_UTIL_HEADERS=ON \
         -DBLUETOOTH_AUDIO_SUPPORT=ON \
         -DBLUETOOTH_GATT_SUPPORT=ON \
+        -DBLUETOOTH_SUPPORT=ON \
+        -DBROADCAST=ON \
+        -DDOWNLOAD_BLUEZ_UTIL_HEADERS=ON \
+        -DHIBERNATESUPPORT=ON \
+        -DHIBERNATE_CHECKPOINTSERVER=ON \
         -DLOCALTRACER=ON \
-        -DWARNING_REPORTING=ON \
+        -DPERFORMANCE_MONITOR=ON \
+        -DPRIVILEGEDREQUEST=ON \
         -DPROCESSCONTAINERS=ON \
         -DPROCESSCONTAINERS_RUNC=ON \
-        -DBROADCAST=ON \
-        -DPERFORMANCE_MONITOR=ON \
+        -DWARNING_REPORTING=ON \
         ${{steps.regexthunder.outputs.first_match}}
         cmake --build ${{matrix.build_type}}/build/Thunder --target install
 

Source/extensions/hibernate/checkpointserver/CheckpointServer.c

@@ -23,6 +23,7 @@
 
 #include <arpa/inet.h>
 #include <assert.h>
+#include <errno.h>
 #include <stdbool.h>
 #include <stdlib.h>
 #include <sys/socket.h>
@@ -79,7 +80,8 @@ static int Connect(const char* serverLocator, uint32_t timeoutMs)
         }
 
         addrUn.sun_family = PF_UNIX;
-        strncpy(addrUn.sun_path, serverLocator, sizeof(addrUn.sun_path));
+        strncpy(addrUn.sun_path, serverLocator, sizeof(addrUn.sun_path) - 1);
+        addrUn.sun_path[sizeof(addrUn.sun_path) - 1] = '\0';
         addr = (struct sockaddr*)&addrUn;
         addrSize = sizeof(struct sockaddr_un);
     } else {
@@ -90,11 +92,12 @@ static int Connect(const char* serverLocator, uint32_t timeoutMs)
             return -1;
         }
 
-        strncpy(host, serverLocator, 64);
+        strncpy(host, serverLocator, sizeof(host) - 1);
+        host[sizeof(host) - 1] = '\0';
         port = strstr(host, ":");
         if (port == NULL) {
             LOGERR("Invalid Server Ip Address: %s", host);
-            return false;
+            return -1;
         }
 
         // Add NULL delimer between host and port
@@ -125,7 +128,6 @@ static bool SendRcvCmd(const ServerRequest* cmd, ServerResponse* resp, uint32_t
 {
     int cd;
     int ret;
-    struct sockaddr_in addr = { 0 };
     resp->respCode = MEMCR_ERROR;
 
     cd = Connect(serverLocator, timeoutMs);
@@ -136,14 +138,14 @@ static bool SendRcvCmd(const ServerRequest* cmd, ServerResponse* resp, uint32_t
 
     ret = write(cd, cmd, sizeof(ServerRequest));
     if (ret != sizeof(ServerRequest)) {
-        LOGERR("Socket write failed: ret %d, %m", ret);
+        LOGERR("Socket write failed: ret %d, errno %d", ret, errno);
         close(cd);
         return false;
     }
 
     ret = read(cd, resp, sizeof(ServerResponse));
     if (ret != sizeof(ServerResponse)) {
-        LOGERR("Socket read failed: ret %d, %m", ret);
+        LOGERR("Socket read failed: ret %d, errno %d", ret, errno);
         resp->respCode = MEMCR_SOCKET_READ_ERROR;
         close(cd);
         return false;
@@ -154,7 +156,7 @@ static bool SendRcvCmd(const ServerRequest* cmd, ServerResponse* resp, uint32_t
     return (resp->respCode == MEMCR_OK);
 }
 
-uint32_t HibernateProcess(const uint32_t timeout, const pid_t pid, const char data_dir[], const char volatile_dir[], void** storage)
+uint32_t HibernateProcess(const uint32_t timeout, const pid_t pid, const char data_dir[], const char volatile_dir[] __attribute__((unused)), void** storage __attribute__((unused)))
 {
     ServerRequest req = {
         .reqCode = MEMCR_CHECKPOINT,
@@ -174,7 +176,7 @@ uint32_t HibernateProcess(const uint32_t timeout, const pid_t pid, const char da
     }
 }
 
-uint32_t WakeupProcess(const uint32_t timeout, const pid_t pid, const char data_dir[], const char volatile_dir[], void** storage)
+uint32_t WakeupProcess(const uint32_t timeout, const pid_t pid, const char data_dir[], const char volatile_dir[] __attribute__((unused)), void** storage __attribute__((unused)))
 {
     ServerRequest req = {
         .reqCode = MEMCR_RESTORE,

Source/extensions/hibernate/common/Log.h

@@ -6,5 +6,5 @@
 #define MODULE      "Hibernate"
 #endif
 
-#define LOGINFO(fmt, ...) do { fprintf(stdout, MODULE " [%s:%d] " fmt "\n", __FUNCTION__, __LINE__, ##__VA_ARGS__);fflush(stdout); } while (0)
-#define LOGERR(fmt, ...) do { fprintf(stderr, MODULE " [%s:%d] " fmt "\n", __FUNCTION__, __LINE__, ##__VA_ARGS__);fflush(stderr); } while (0)
+#define LOGINFO(fmt, ...) do { fprintf(stdout, MODULE " [%s:%d] " fmt "\n", __func__, __LINE__, ##__VA_ARGS__);fflush(stdout); } while (0)
+#define LOGERR(fmt, ...) do { fprintf(stderr, MODULE " [%s:%d] " fmt "\n", __func__, __LINE__, ##__VA_ARGS__);fflush(stderr); } while (0)

Source/extensions/privilegedrequest/include/privilegedrequest/PrivilegedRequest.h

@@ -335,9 +335,9 @@ namespace Core {
                 }
 
                 ASSERT(strlen(binder) < MaxFilePathLength);
-
+PUSH_WARNING(DISABLE_WARNING_UNUSED_RESULT)
                 ::mkstemp(binder);
-
+POP_WARNING()
                 return (string(binder));
             }
             int OpenDomainSocket(const string& connector) const

Source/plugins/IController.h

@@ -262,7 +262,7 @@ namespace Controller {
                 enum extensiontype : uint8_t {
                     WARNING_REPORTING = 1,
                     BLUETOOTH = 2,
-                    HIBERBATE = 4,
+                    HIBERNATE = 4,
                     PROCESS_CONTAINERS = 8
                 };