Skip to content

Remove ThreadRAII #4851

@npoltorapavlo

Description

@npoltorapavlo

The documentation says "...to avoid std::terminate exception. Use the ThreadRAII class for creating threads which will ensure that the thread gets joined before destruction". Please remove this and also remove ThreadRAII because it produces segfaults. std::terminate exception that you are trying to avoid points out the place in code that is not implemented correctly. It gives a full callstack as well. Compare this to a typical use of ThreadRAII:

A member;
ThreadRAII thread; // thread calls member
member destroys -> thread runs in join() -> segfault with unknown address/pure virtual call

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions