Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Margin is handled wrong. #385

Open
IceReaper opened this issue Dec 14, 2022 · 0 comments · May be fixed by #386
Open

Margin is handled wrong. #385

IceReaper opened this issue Dec 14, 2022 · 0 comments · May be fixed by #386

Comments

@IceReaper
Copy link
Contributor

When adding two TextButton for example in a VerticalStackPanel, giving both a fixed height and the first one a margin-bottom, i expect the buttons to have the same height. However it seems that the Height property includes margins, so the first button ends up being smaller.

While one could argument that this is the box-model myra uses, its super unconvenient because i wont be able to "make all buttons equal heigh". It needs every single buttons height to be calculated with added margin top-bottom.

This is either a bug in the layout formula, or if this is on purpose, i would request a change on how margins are applied. Width / Height should never contain the Margin value.

This strongly reminds me of #376

@IceReaper IceReaper linked a pull request Dec 16, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant