TypeScript typings rely on nonexistent @react-navigation/core libdefs

[jakub-astrahit]

Hi, I just installed react-navigation-redux-helpers and am having issues with the TypeScript typings

node_modules/react-navigation-redux-helpers/index.d.ts:9:10 - error TS7016: Could not find a declaration file for module '@react-navigation/core'. '/Users/foo/ui/node_modules/@react-navigation/core/lib/commonjs/index.js' implicitly has an 'any' type.
  Try `npm install @types/react-navigation__core` if it exists or add a new declaration (.d.ts) file containing `declare module '@react-navigation/core';`

9   } from '@react-navigation/core';

My implementation:

import React from 'react'
import { createStackNavigator, NavigationParams, NavigationRoute, NavigationScreenProp } from 'react-navigation'
import { createReduxContainer } from 'react-navigation-redux-helpers'
import { connect } from 'react-redux'
import { AppState } from './store'

export const screens = strEnum([
    'FOO',
])
export type Screen = keyof typeof screens
export const getDefaultNavigationOptions = ({ navigation }: any) => ({
    header: <Header header={navigation.getParam('header')} />,
})
export const AppNavigator = createStackNavigator(
    {
        [screens.FOO]: {
            screen: FooScreen,
            params: { header: { title: 'Foo.Title' } },
        },
       
    },
    {
        initialRouteName: screens.FOO,
        headerMode: 'float',
        defaultNavigationOptions: getDefaultNavigationOptions,
    },
)

const mapStateToProps = (state: AppState) => ({
    state: state.navigation,
})

const NavContainer: React.FC = () => {
    const Navigator = connect(mapStateToProps)(createReduxContainer(AppNavigator))
    return <Navigator />
}

export default NavContainer

Here is the contents of the node_modules/react-navigation-redux-helpers/index.d.ts file:

declare module 'react-navigation-redux-helpers' {
  import {
    NavigationContainer,
    NavigationEventCallback,
    NavigationEventSubscription,
    NavigationState,
    NavigationDispatch,
    NavigationScreenProp
  } from '@react-navigation/core';
...

Any ideas what's wrong with the typings on the last line? '@react-navigation/core';

[Ashoat]

I don't use TypeScript or maintain the typings for it but it looks like you should install the types for the @react-navigation/core

[jakub-astrahit]

@Ashoat I use "@types/react-navigation": "^3.0.8" and it does not work. There's no separate types for core.

[Ashoat]

Okay, I’ve reopened this issue and assigned it to you in the hopes you will do something about it. Again I don’t maintain the TypeScript typings so need somebody else to take the lead

[Ashoat]

A good start would be to tag in the previous maintainers of these typings. Why aren’t they having the same issue? Perhaps you have misconfigured something?