Skip to content

Components can't be passed through props since the defaults come after the prop in the object spread #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dtaub opened this issue Mar 9, 2017 · 1 comment

Comments

@dtaub
Copy link

dtaub commented Mar 9, 2017

Should ...components be on the bottom?

    const tableComponents = {
      ...components,
      body: {
        wrapper: Virtualized.BodyWrapper,
        row: dnd.draggableRow(Virtualized.BodyRow)
      }
    };

Mainly I just want to override shouldComponentUpdate(). Is there any easier way to do that?

@bebraw
Copy link
Member

bebraw commented Mar 9, 2017

The order could be changed, yeah. The potential problem is that if you override either wrapper or row, then it may break functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants