What is the recommended approach for resolving these two warnings?

[NeverMorewd]

[IL2026] Using member 'ReactiveUI.IReactiveNotifyPropertyChanged<TSender>.SuppressChangeNotifications()' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. SuppressChangeNotifications uses extension methods that may require unreferenced code.

[IL2026] Using member 'ReactiveUI.ReactiveObject.SuppressChangeNotifications()' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. This method uses reflection to access properties by name.

[dabbinavo]

I am also searching for an answer to that question. This is related to #4018
As far as I know, there is no possibility to suppress specific warnings coming from an referenced package.

@glennawatson , do you know a way to suppress these warnings without

1. having to add 1.000+ annotations to the own methods which leads to a pretty ugly codebase
2. suppressing the warnings globally for the entire project/codebase (which would also hide real issue warnings)

[glennawatson]

Unfortunately Microsoft hasn't really given a way to suppress warnings from a particular library as far as I'm aware.

[dabbinavo]

Well, I added now thousands of annotations to my own code base in order to suppress the ReactiveUI NativeAOT warnings.

I understand that it might be cumbersome work to annotate the whole ReactiveUI project including Splat.
But I am motivated to dive into the code in order to see if I can contribute annotation fixes for some of the methods that are used quite often (e.g. WhenAnyValue(...)).

Unfortunately, I find it hard to start, as I do not understand, why the annotations were introduced on some places. Maybe I have the wrong setup or workflow for analyzing this.

• Checked out the ReactiveUI main branch
• Installed all the dotnet workloads in order to be able to build the project
• Having the project open in VSCode with the C# extension
• Using ReactiveUI.sln as the solution
• Running dotnet build -f net10.0 from src/ReactiveUI/

When I remove the annotation attributes RequiresDynamicCode and RequiresUnreferencedCode from that function:

ReactiveUI/src/ReactiveUI/Mixins/ExpressionMixins.cs

Lines 120 to 140 in 398bfae

	/// <summary>
	/// Gets the parent Expression of the current Expression object.
	/// </summary>
	/// <param name="expression">The expression.</param>
	/// <returns>The parent expression.</returns>
	#if NET6_0_OR_GREATER
	[RequiresDynamicCode("Expression analysis requires dynamic code generation")]
	[RequiresUnreferencedCode("Expression analysis may reference members that could be trimmed")]
	#endif
	public static Expression? GetParent(this Expression expression) // TODO: Create Test
	{
	expression.ArgumentNullExceptionThrowIfNull(nameof(expression));
	return expression.NodeType switch
	{
	ExpressionType.Index when expression is IndexExpression indexExpression => indexExpression.Object,
	ExpressionType.MemberAccess when expression is MemberExpression memberExpression => memberExpression
	.Expression,
	_ => throw new NotSupportedException($"Unsupported expression type: '{expression.NodeType}'")
	};
	}

Neither intellisense, nor dotnet build gives me a warning that there is an issue with that function. Why were the annoations introduced for that function?

I think I need to first understand some basics about that topic and how to identify the issues before being able to contribute.

Please, can you help me with this, @ChrisPulman or @glennawatson?

[glennawatson]

Couple things, we'd need to do the evaluation in order of dependency libraries. Eg Splat, then RxUI.

Since Splat is where the majority of the IL warnings come from we'd have to wait until I did a sweep through that library first.

Also #4239 is a pre-requisite for any of this work.

I'd prefer to do the work myself on this one but thanks for the willingness to jump in and help.

[dabbinavo]

I created a pull request draft for fixing incorrect warnings for some of the most used methods: #4242
Everyone also struggling witht that issue and having time to help contributing, feel free.

[glennawatson]

We are in the midst some changes, and already in the midst of working on this problem and taking another approach. Unfortunately for the moment just going to close the PR but thanks for helping out regardless appreciate it.